trace-forward: new API for acceptor's part. #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
denisshevchenko
requested review from
DavidEichmann,
dcoutts,
deepfire,
erikd,
JaredCorduan,
Jimbo4350,
jutaro,
nc6 and
newhoggy
as code owners
deepfire
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
@denisshevchenko, s/Asker/Requestor, otherwise it's perfect!
denisshevchenko
force-pushed
the
new-trace-forward
branch
from
d32d5d9
to
945a188
Compare
iohk-bors bot
added a commit
that referenced
this pull request
Jan 13, 2022
3496: trace-forward: new API for acceptor's part. r=denisshevchenko a=denisshevchenko This PR changes API of the acceptor's part only, it doesn't touch the forwarder's part (used by `trace-dispatcher`): 1. `IO`-action returning `DataPointAsker` is provided. It allows avoiding `unsafePerformIO` in the acceptor application. 2. Peer error handlers were added. It allows the acceptor application to know if the connection with the node was dropped. Additionally: 1. `ekg-forward` dependency is updated. 2. `DataPoint` protocol is fixed: now there is a check if the reply with `DataPoint`s is empty. **Please note that `cardano-tracer` service, the next part of the new tracing infrastructure, depends on this PR. After it will be merged, the PR for `cardano-tracer` will be opened.** Co-authored-by: Denis Shevchenko <denis.shevchenko@iohk.io>
Jimbo4350
approved these changes
Jan 13, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes API of the acceptor's part only, it doesn't touch the forwarder's part (used by
trace-dispatcher):IO-action returningDataPointAskeris provided. It allows avoidingunsafePerformIOin the acceptor application.Additionally:
ekg-forwarddependency is updated.DataPointprotocol is fixed: now there is a check if the reply withDataPoints is empty.Please note that
cardano-tracerservice, the next part of the new tracing infrastructure, depends on this PR. After it will be merged, the PR forcardano-tracerwill be opened.