Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more context to invalid snapshot events #5933

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Aug 1, 2024

Description

This PR adds a bit of context for when deserializing the ledger snapshot fails. Almost aways (apart from bugs/file corruption), this is due to an expected change in the serialization format, which currently requires replaying from Genesis. In the future, the Ledger team might implement migration/upgrade logic for this case, see IntersectMBO/cardano-ledger#3220.

See #5908 for a recent example for users being puzzled by this message.

I opted to only modify the "human" representation, but I don't have a strong opinion here.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@amesgen amesgen requested a review from a team as a code owner August 1, 2024 09:55
@amesgen amesgen enabled auto-merge August 1, 2024 10:02
Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really useful. I will try to rebase it,

@erikd erikd force-pushed the amesgen/invalid-snapshot-msg branch from 0140f76 to 643f381 Compare September 13, 2024 04:10
Copy link
Contributor

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amesgen amesgen added this pull request to the merge queue Sep 13, 2024
@erikd erikd added this pull request to the merge queue Sep 13, 2024
Merged via the queue into master with commit 82dfb84 Sep 13, 2024
24 of 25 checks passed
@erikd erikd deleted the amesgen/invalid-snapshot-msg branch September 13, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants