-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cardano-node 9.2.0 release #5944
Conversation
14c4760
to
d2c1efb
Compare
d3584a5
to
e7bb489
Compare
436a87d
to
4e40ff7
Compare
a63eb80
to
0ff6cbe
Compare
40addcd
to
7a3b8a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments. I won't "Request changes" because they maybe are not worth blocking the release.
common maybe-Win32 | ||
if os(windows) | ||
build-depends: Win32 | ||
common maybe-Win32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some trailing whitespaces, not particularly important
fmap OnePathForAllDbs $ | ||
strOption $ | ||
mconcat | ||
[ long "database-path" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cli argument says ...-path
indeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a but worried about so many tests being disabled. But maybe it is OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine. It's due to test flakiness which @carbolymer will look in to soon.
d1aed19
to
415282d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jimbo4350 !
node configuration yaml file
Fix cabal.project Update TraceLastShutdownUnclean's severity annotation to Warning
415282d
to
ac6e894
Compare
Description
Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.