Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-node 9.2.0 release #5944

Merged
merged 17 commits into from
Sep 18, 2024
Merged

cardano-node 9.2.0 release #5944

merged 17 commits into from
Sep 18, 2024

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Aug 7, 2024

Description

  • Volatile and immutable database paths can now be specified separately with either:
    • The new command line options:
    ...
      [ --database-path FILEPATH
      | --immutable-database-path FILEPATH --volatile-database-path FILEPATH
      ]
    ...
    
    • In the config yaml file via the new "DatabaseFile" key:
      ...
      "DatabasePath": {
      "ImmutableDbPath": "mainnetnode/db/node-imm",
      "VolatileDbPath": "mainnetnode/db/node-vol"
      },
      ...
    
    or
      "DatabasePath": "mainnetsingle/db/node",
    

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@Jimbo4350 Jimbo4350 mentioned this pull request Aug 7, 2024
6 tasks
@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-chap-20240807 branch 4 times, most recently from d3584a5 to e7bb489 Compare September 5, 2024 21:13
@Jimbo4350 Jimbo4350 changed the title Bump CHaP Cardano-node 9.2.0 release Sep 5, 2024
@Jimbo4350 Jimbo4350 changed the title Cardano-node 9.2.0 release cardano-node 9.2.0 release Sep 5, 2024
@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-chap-20240807 branch 20 times, most recently from 436a87d to 4e40ff7 Compare September 11, 2024 17:04
@Jimbo4350 Jimbo4350 marked this pull request as ready for review September 11, 2024 17:04
@Jimbo4350 Jimbo4350 requested a review from a team as a code owner September 11, 2024 17:04
@Jimbo4350 Jimbo4350 force-pushed the jordan/bump-chap-20240807 branch 2 times, most recently from 40addcd to 7a3b8a7 Compare September 13, 2024 19:06
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. I won't "Request changes" because they maybe are not worth blocking the release.

cabal.project Outdated Show resolved Hide resolved
common maybe-Win32
if os(windows)
build-depends: Win32
common maybe-Win32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some trailing whitespaces, not particularly important

cardano-node/src/Cardano/Node/Configuration/POM.hs Outdated Show resolved Hide resolved
fmap OnePathForAllDbs $
strOption $
mconcat
[ long "database-path"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cli argument says ...-path indeed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a but worried about so many tests being disabled. But maybe it is OK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. It's due to test flakiness which @carbolymer will look in to soon.

Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jimbo4350 !

@Jimbo4350 Jimbo4350 added this pull request to the merge queue Sep 18, 2024
Merged via the queue into master with commit 341ea87 Sep 18, 2024
26 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/bump-chap-20240807 branch September 18, 2024 17:37
@crocodile-dentist crocodile-dentist mentioned this pull request Oct 15, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants