Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toplevel changelog #5959

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

aleeusgr
Copy link
Contributor

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

closes #5874

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@aleeusgr aleeusgr requested a review from a team as a code owner August 23, 2024 05:31
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@carbolymer
Copy link
Contributor

@aleeusgr Can you sign your commits please? That's our requirement for all changes in the node. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@aleeusgr
Copy link
Contributor Author

aleeusgr commented Sep 12, 2024

@carbolymer hello!

I am confused a bit, I did the following:
git commit --amend --signoff
git push origin add-toplevel-changelog -f

now the commit message contains my name and email, does it mean its signed?

Thank you!

@erikd
Copy link
Contributor

erikd commented Sep 13, 2024

now the commit message contains my name and email, does it mean its signed

git log --format=raw show the log in the raw format which includes a crypto signing block.

Signed-off-by: Alex <alexeusgr@gmail.com>
@aleeusgr
Copy link
Contributor Author

aleeusgr commented Sep 17, 2024

Thanks!
It was not signed, I fixed my git and now It looks signed.

@carbolymer
Copy link
Contributor

@aleeusgr I think you just need to upload your public key to github
image

@aleeusgr
Copy link
Contributor Author

aleeusgr commented Sep 18, 2024

@carbolymer thanks!

Added GPG key to my GitHub account.

KeyID: 6A7D30C3EFF7B815

@carbolymer carbolymer merged commit f7b901e into IntersectMBO:master Sep 20, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Doc Required by OSC Governance
3 participants