Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-tracer: Allow switching EKG service between different nodes. #5975

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Icelandjack
Copy link
Contributor

@Icelandjack Icelandjack commented Sep 4, 2024

Description

  • Main issue: EKG servers cannot be restarted with the same store. To work around this limitation a new type (RouteDictionary) is defined that associates a store to each of the (slugified) node names.
    • This creates a dynamic routing to EKG stores of all connected nodes.
  • Phase out HsOpenSSL: replace snap webserver with wai/warp.
  • The hasEKG field of TracerEnv matches hasPrometheus in defining a single port (endpoint).
  • (for optional RTView) Disable SSL/https connections. Force snap-server dependency to build with -flag -openssl.
  • JSON responses when listing connected nodes for Prometheus and EKG Monitoring.
  • Consistency check for redundant port values in the config.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated.
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@Icelandjack Icelandjack requested review from a team as code owners September 4, 2024 11:50
@Icelandjack Icelandjack marked this pull request as draft September 4, 2024 11:50
@Icelandjack Icelandjack force-pushed the baldurb/ekg-restart branch 4 times, most recently from 98a2e33 to 295f24c Compare September 9, 2024 14:21
@Icelandjack Icelandjack force-pushed the baldurb/ekg-restart branch 20 times, most recently from 0cff156 to f4faadb Compare September 20, 2024 15:53
@Icelandjack Icelandjack force-pushed the baldurb/ekg-restart branch 7 times, most recently from 7c24c0d to 43b8056 Compare September 23, 2024 13:32
@Icelandjack Icelandjack marked this pull request as ready for review September 23, 2024 13:34
@Icelandjack Icelandjack requested review from a team as code owners September 23, 2024 13:34
@Icelandjack Icelandjack force-pushed the baldurb/ekg-restart branch 12 times, most recently from 206e8be to 13a97d0 Compare September 25, 2024 11:05
Copy link
Contributor

@mgmeier mgmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you so much @Icelandjack !

@mgmeier mgmeier added this pull request to the merge queue Sep 25, 2024
Merged via the queue into master with commit ea98b81 Sep 25, 2024
23 checks passed
@mgmeier mgmeier deleted the baldurb/ekg-restart branch September 25, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants