Release 10.2.0 #6050
Draft
Release 10.2.0 #6050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodile-dentist
force-pushed
the
nm/release-srp
branch
2 times, most recently
from
cf9f8a9 to
f1a8f7f
Compare
coot
reviewed
Dec 5, 2024
Comment on lines
+182
to
+189
| args = ConnectToArgs { | ||
| ctaHandshakeCodec = codecHandshake forwardingVersionCodec, | ||
| ctaHandshakeTimeLimits = timeLimits, | ||
| ctaVersionDataCodec = cborTermVersionDataCodec forwardingCodecCBORTerm, | ||
| ctaConnectTracers = nullNetworkConnectTracers, | ||
| ctaHandshakeCallbacks = HandshakeCallbacks acceptableVersion queryVersion } |
There was a problem hiding this comment.
Extra space will make things more readable, similar in other places.
Suggested change
| args = ConnectToArgs { | |
| ctaHandshakeCodec = codecHandshake forwardingVersionCodec, | |
| ctaHandshakeTimeLimits = timeLimits, | |
| ctaVersionDataCodec = cborTermVersionDataCodec forwardingCodecCBORTerm, | |
| ctaConnectTracers = nullNetworkConnectTracers, | |
| ctaHandshakeCallbacks = HandshakeCallbacks acceptableVersion queryVersion } | |
| args = ConnectToArgs { | |
| ctaHandshakeCodec = codecHandshake forwardingVersionCodec, | |
| ctaHandshakeTimeLimits = timeLimits, | |
| ctaVersionDataCodec = cborTermVersionDataCodec forwardingCodecCBORTerm, | |
| ctaConnectTracers = nullNetworkConnectTracers, | |
| ctaHandshakeCallbacks = HandshakeCallbacks acceptableVersion queryVersion } | |
crocodile-dentist
force-pushed
the
nm/release-srp
branch
3 times, most recently
from
b14a949 to
abd035b
Compare
neilmayhew
force-pushed
the
nm/release-srp
branch
2 times, most recently
from
f8e48d4 to
f2977ec
Compare
neilmayhew
force-pushed
the
nm/release-srp
branch
from
6a6942e to
4eb622b
Compare
* ConsensusMode * MinBigLedgerPeersForTrustedState
neilmayhew
force-pushed
the
nm/release-srp
branch
from
d59113c to
9252209
Compare
- Categorise `LedgerDB.SnapshotMissingChecksum` trace as `Warning` - Expose snapshot checksum switch in config file
…dsToShelleyBasedEra
neilmayhew
force-pushed
the
nm/release-srp
branch
from
9252209 to
222bb5d
Compare
coot
reviewed
Dec 16, 2024
| @@ -2059,6 +2146,10 @@ instance Show lAddr => ToObject (PeerSelectionActionsTrace SockAddr lAddr) where | |||
| , "connectionId" .= toJSON connId | |||
| , "withProtocolTemp" .= show wf | |||
| ] | |||
| toObject _verb (AcquireConnectionError exception) = | |||
| mconcat [ "kind" .= String "AcquireConnectionError" | |||
| , "exception" .= displayException exception | |||
There was a problem hiding this comment.
Just for the sake of consistency with other places:
Suggested change
| , "exception" .= displayException exception | |
| , "error" .= displayException exception |
| @@ -1137,18 +1143,24 @@ instance Show lAddr => LogFormatting (PeerSelectionActionsTrace SockAddr lAddr) | |||
| , "connectionId" .= toJSON connId | |||
| , "withProtocolTemp" .= show wf | |||
| ] | |||
| forMachine _dtal (AcquireConnectionError exception) = | |||
| mconcat [ "kind" .= String "AcquireConnectionError" | |||
| , "exception" .= displayException exception | |||
There was a problem hiding this comment.
Suggested change
| , "exception" .= displayException exception | |
| , "error" .= displayException exception |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes for v10.2.0
Closes #6040
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.