Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano: Disable p2p for preview and preprod networks #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

YorikSar
Copy link
Contributor

Following the example from input-output-hk/cardano-configurations@319805a create _p2p directories for networks that might have p2p enabled, but keep it off by default.

Copy link
Collaborator

@disassembler disassembler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR would be disastrous. We can't change preview/preprod to not use p2p. The entire network depends on that being enabled.

@YorikSar YorikSar force-pushed the disable-p2p-default branch 2 times, most recently from 868ec9d to 412825a Compare September 19, 2022 15:54
Current snapshot is already gone from the bucket.
Makes it fail on HTTP errors instead of finishing successfully and
outputting garbage to out file.
Following the example from
input-output-hk/cardano-configurations@319805a
create _p2p directories for networks that might have p2p enabled, but
keep it off by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants