Added an API module to the executable spec, removed Lib #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/reorganize-exec-spec
branch
from
3e4644a to
96ba986
Compare
Soupstraw
changed the title
Foreign modules in the executable spec, removed Lib
Soupstraw
force-pushed
the
jj/reorganize-exec-spec
branch
from
96ba986 to
7e43262
Compare
omelkonian
requested changes
Nov 1, 2023
Comment on lines
+125
to
+128
| installPhase = '' | ||
| mv $out/haskell/${main}/* $out | ||
| rm -rf $out/haskell | ||
| ''; |
There was a problem hiding this comment.
NB: we now have to be careful not to generate both Ledger and MidnightExample under the same directory.
There was a problem hiding this comment.
I'm not sure what you mean by that, Nix has different outputs for midnight and ledger, so that shouldn't ever happen
There was a problem hiding this comment.
c.f. build.yml, where we call nix-build twice (once for Ledger and once for MidnightExample but then rsync their output folders under a common docs/ folder.
There was a problem hiding this comment.
oh, yeah, that's going to cause problems
Soupstraw
force-pushed
the
jj/reorganize-exec-spec
branch
from
7e43262 to
20bb449
Compare
Soupstraw
force-pushed
the
jj/reorganize-exec-spec
branch
from
20bb449 to
793c07b
Compare
Soupstraw
force-pushed
the
jj/reorganize-exec-spec
branch
from
793c07b to
9f5dd82
Compare
|
@Soupstraw do you still plan on continuing this? |
|
Closing this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Libis a bit too ambiguous to use incardano-ledgerconformance tests, so I exposed theForeignmodules directly instead.Checklist