Skip to content

Commit

Permalink
Merge pull request #172 from IntersectMBO/171-enhance-deployment-scri…
Browse files Browse the repository at this point in the history
…pt-for-conditional-generation-of-basicauth-configuration-files

[#171] Remove Nginx config post-deployment to prevent configuration reuse across environments
  • Loading branch information
placek authored Feb 14, 2024
2 parents c52c7cf + cb346bc commit 1298853
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
16 changes: 16 additions & 0 deletions docs/operations/DEPLOY.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,19 @@ Alternatively you can type `make all instance=$INSTANCE cardano_network=$CARDANO

View the app at `https://${ENVIRONMENT}-${INSTANCE}.govtool.byron.network`.
Keep in mind that after initial deployment on a new environment, it will take some time for the Cardano node to get in sync.

## Aftermatch

After performing a deploy from a local machine, it is crucial to carefully track
the application's accessibility and functionality to ensure no unintended
changes, such as the accidental activation of BasicAuth[^1], have occurred.

Additionally, verifying that all configuration files and environment variables,
particularly those related to environment-specific settings like database
connections or external service endpoints, are correctly generated and applied
is essential for maintaining the intended behavior of the application across
different environments. This includes a thorough check of environment variables
to confirm they are correctly set and aligned with the specific needs of the
deployed environment.

[^1]: https://github.com/IntersectMBO/govtool/discussions/174
1 change: 1 addition & 0 deletions scripts/govtool/prepare-config.sh
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ sed -e "s/GRAFANA_SLACK_RECIPIENT/$GRAFANA_SLACK_RECIPIENT/" \

# nginx config for frontend optional basic auth
nginx_config_dir="$target_config_dir/nginx"
rm -rf "$nginx_config_dir"
mkdir -p "$nginx_config_dir"
if [[ "$DOMAIN" == *"sanchonet.govtool.byron.network"* ]]; then
cat >"$nginx_config_dir/auth.conf" <<_EOF_
Expand Down

0 comments on commit 1298853

Please sign in to comment.