fix(#2398): fix unnecessary node remove in metadata actions

IntersectMBO · Dec 3, 2024 · b931f80 · b931f80
1 parent 3b2b867
commit b931f80
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@ changes.
 
 - Fix fetching voting power of newly registerd DRep [Issue 2407](https://github.com/IntersectMBO/govtool/issues/2407)
 - Fix inconsistent voting status [Issue 1713](https://github.com/IntersectMBO/govtool/issues/1713)
+- Fix removing a child (link) when is not registed in DOM [Issue 2398](https://github.com/IntersectMBO/govtool/issues/2398)
 
 ### Changed
 

diff --git a/govtool/frontend/src/utils/jsonUtils.ts b/govtool/frontend/src/utils/jsonUtils.ts
@@ -24,8 +24,6 @@ export const downloadJson = (json: NodeObject, fileName?: string) => {
   } else {
     link.click();
   }
-
-  document.body.removeChild(link);
   URL.revokeObjectURL(url);
 };
 
@@ -52,6 +50,5 @@ export const downloadTextFile = (text: string, fileName?: string) => {
     link.click();
   }
 
-  document.body.removeChild(link);
   URL.revokeObjectURL(url);
 };