Merge pull request #2480 from IntersectMBO/develop

fix(#2478): fix double signing of transaction
IntersectMBO · Dec 6, 2024 · f3ecac2 · f3ecac2
2 parents 51fd5c1 + c25912d
commit f3ecac2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -39,6 +39,7 @@ changes.
 - Fix removing a child (link) when is not registed in DOM [Issue 2398](https://github.com/IntersectMBO/govtool/issues/2398)
 - Fix blank screen on DRep delegation when UTXos are missing [Issue 2408](https://github.com/IntersectMBO/govtool/issues/2408)
 - Fix broken guides links [Issue 2417](https://github.com/IntersectMBO/govtool/issues/2417)
+- Fix double signing of transaction [Issue 2478](https://github.com/IntersectMBO/govtool/issues/2478)
 
 ### Changed
 

diff --git a/govtool/frontend/src/context/wallet.tsx b/govtool/frontend/src/context/wallet.tsx
@@ -674,12 +674,9 @@ const CardanoProvider = (props: Props) => {
         // Make a full transaction, passing in empty witness set
         const tx = Transaction.new(txBody, transactionWitnessSet);
         // Ask wallet to to provide signature (witnesses) for the transaction
-        let txVkeyWitnesses;
-
-        txVkeyWitnesses = await walletApi.signTx(tx.to_hex(), true);
 
         // Create witness set object using the witnesses provided by the wallet
-        txVkeyWitnesses = TransactionWitnessSet.from_bytes(
+        const txVkeyWitnesses = TransactionWitnessSet.from_bytes(
           Buffer.from(await walletApi.signTx(tx.to_hex(), true), "hex"),
         );
         const vkeys = txVkeyWitnesses.vkeys();