Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing test ids (Governance Action proposal) #1070

Closed
kneerose opened this issue May 22, 2024 · 5 comments · Fixed by #1080 or #1147
Closed

[BUG] Missing test ids (Governance Action proposal) #1070

kneerose opened this issue May 22, 2024 · 5 comments · Fixed by #1080 or #1147
Labels
🐛 Bug Something isn't working

Comments

@kneerose
Copy link
Contributor

Description

Missing Test Ids

  • On create governance action proposal form fields
    • title-input for the title input field
    • abstract-input for the abstract input field
    • motivation-input for the motivation input field
    • rationale-input for the rationale input field
    • receiving-address-input for the receiving address field
    • amount-input for the amount input field
    • link-input for the link input field
    • add-link-button for the "Add Link" button

image

  • On review fillup proposal form
    • edit-submission-button for the edit submission button
    • governance-action-type-content
    • governance-action-abstract-content
    • governance-action-motivation-content
    • governance-action-rationale-content
    • governance-action-receiving-address-content
    • governance-action-amount-content
    • governance-action-link-content

Screenshot from 2024-05-22 13-55-03

  • On information storage steps
    • metadata-download-button
    • metadata-url

Screenshot from 2024-05-22 14-18-58

@NabinKawan NabinKawan added the 🐛 Bug Something isn't working label May 22, 2024
@MSzalowski MSzalowski moved this to To do in Govtool all May 23, 2024
@MSzalowski MSzalowski removed their assignment May 23, 2024
@Sworzen1 Sworzen1 moved this from To do to In progress in Govtool all May 23, 2024
@Sworzen1 Sworzen1 moved this from In progress to In review in Govtool all May 23, 2024
@Sworzen1 Sworzen1 self-assigned this May 23, 2024
@Sworzen1 Sworzen1 linked a pull request May 23, 2024 that will close this issue
5 tasks
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all May 27, 2024
@Sworzen1 Sworzen1 moved this from Done to In QA in Govtool all May 27, 2024
@pmbinapps
Copy link

OK On Edit page:
Test ID found: title-input
Test ID found: abstract-input
Test ID found: motivation-input
Test ID found: rationale-input
Test ID found: receiving-address-input
Test ID found: amount-input
Test ID not found: link-input --> link-1-input OK
Test ID found: add-link-button

@pmbinapps
Copy link

NOT OK - on content page, ids have new line char, eg:

Image

@pmbinapps pmbinapps moved this from In QA to To do in Govtool all Jun 3, 2024
@Sworzen1 Sworzen1 moved this from To do to In review in Govtool all Jun 3, 2024
@Sworzen1 Sworzen1 linked a pull request Jun 3, 2024 that will close this issue
5 tasks
@Sworzen1 Sworzen1 moved this from In review to In QA in Govtool all Jun 5, 2024
@pmbinapps
Copy link

OK NOW:

DIV text: A 899448.985635| data-testid: voting-power-chips svg text: [undefined| data-testid: InfoOutlinedIcon
P text: A 899448.985635| data-testid: voting-power-chips-value
DIV text: [Back to dashboard| data-testid: Back-to-dashboard-link svg text: [undefined| data-testid: ArrowBackIosIcon
INPUT text: | data-testid: governance-action-type-input
P text: |To change the Governance Action Type go back to the previous page. I data-testid: to-change-the-governance-action-type-go-back-to-the-previous-page.-error
INPUT text: | data-testid: title-input
TEXTAREA text: || data-testid: abstract-input
P text: [General summary of the Action| data-testid: general-summary-of-the-action-error
TEXTAREA text: || data-testid: motivation-input
P text: |How will this solve a problem| data-testid: how-will-this-solve-a-problem-error
TEXTAREA text: || data-testid: rationale-input
P text: |Put all the content of the GA here| data-testid: put-all-the-content-of-the-ga-here-error
INPUT text: || data-testid: receiving-address-input
INPUT text: || data-testid: amount-input
INPUT text: || data-testid: link-1-input
BUTTON text: |+ Add link| data-testid: add-link-button
BUTTON text: Back| data-testid: back-button
BUTTON text: | Continuel data-testid: continue-button
A text: [Privacy policyl data-testid: privacy-policy-footer-link
A text: |Term of servicel data-testid: term-of-service-footer-link
BUTTON text: |Help| data-testid: help-footer-button
BUTTON text: | Feedback| data-testid: feedback-footer-button

@Sworzen1 id for element below seems to be invalid, ends with .-error

P text: |To change the Governance Action Type go back to the previous page. I
data-testid: to-change-the-governance-action-type-go-back-to-the-previous-page.-error

@NabinKawan
Copy link
Contributor

Hi @pmbinapps, Can we close this related issue after merging it into the test branch? We still cannot verify it.

@NabinKawan NabinKawan reopened this Jun 7, 2024
@pmbinapps pmbinapps moved this from In QA to In staging in Govtool all Jun 10, 2024
@MSzalowski MSzalowski moved this from In staging to Done in Govtool all Jun 13, 2024
@kneerose
Copy link
Contributor Author

kneerose commented Jul 22, 2024

I am closing this issue because this functionality has been moved to the proposal creation process. #1237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Status: Done
5 participants