Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing Test IDs #937

Closed
NabinKawan opened this issue May 3, 2024 · 7 comments · Fixed by #959
Closed

[BUG] Missing Test IDs #937

NabinKawan opened this issue May 3, 2024 · 7 comments · Fixed by #959
Labels
🐛 Bug Something isn't working

Comments

@NabinKawan
Copy link
Contributor

NabinKawan commented May 3, 2024

Description:
Several components across various pages lack proper test IDs, impeding effective testing and automation.

DRep Registration Page:

  • Page URL: /register_drep
    Registration Page

    • The testId for the "Continue" button is incorrectly set as retire-button; it should be continue-button.

    • Test IDs for form fields in the DRep registration form are missing:

      • add-link-button for the "Add Link" button.
      • name-input for the name input field.
      • email-input for the email input field.
      • bio-input for the bio input field.
      • link-input for the link input field.

DRep Form Fields

  • The test ID for the "Register" button is incorrectly set as retire-button; it should be register-button.

Register Button

Delegation Page:

  • Page URL: [Provide URL]
    image
    • Test IDs are missing for:
      • delegation-options-dropdown.
      • signal-no-confidence-card.
      • abstain-delegation-card.

Governance Action Details Page:

image
image

  • Test ID for the "Provide Context" button is missing.
  • Test ID for the "Provide Context" input is missing

Retirement Page:

image

  • The test ID for the "Continue" button is incorrect; it should be continue-retirement-button.

Dashboard:

Image

  • Incorrect test ID for "View DRep Directory".
  • Inside the dRep-card, the dRep-id-display-card test ID is conflicting with the sidebar's dRep-id-display-card. Suggest creating distinct test IDs, such as dRep-id-display-card-dashboard for the dashboard.
    image

Mobile

Image

  • test ID missing for open-drawer-button for logged out state

Important: Please ensure to add proper test IDs for all interactive elements to facilitate testing and automation.

@NabinKawan NabinKawan added the 🐛 Bug Something isn't working label May 3, 2024
@MSzalowski MSzalowski removed their assignment May 8, 2024
@MSzalowski MSzalowski moved this to To do in Govtool all May 8, 2024
@JanJaroszczak JanJaroszczak moved this from To do to In progress in Govtool all May 8, 2024
@JanJaroszczak JanJaroszczak self-assigned this May 8, 2024
JanJaroszczak added a commit that referenced this issue May 8, 2024
@JanJaroszczak JanJaroszczak linked a pull request May 8, 2024 that will close this issue
5 tasks
@JanJaroszczak JanJaroszczak moved this from In progress to In review in Govtool all May 8, 2024
JanJaroszczak added a commit that referenced this issue May 8, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all May 8, 2024
@JanJaroszczak JanJaroszczak moved this from Done to In QA in Govtool all May 8, 2024
@SandraRodziewicz SandraRodziewicz self-assigned this May 15, 2024
@pmbinapps
Copy link

For page:

Image

data-testid="Back-to-dashboard-link"
data-testid="ArrowBackIosIcon"
data-testid="name-input"
data-testid="this-is-name-that-will-be-shown-on-your-drep-profile-error"
data-testid="email-input"
data-testid="bio-input"
data-testid="some-sentence-about-yourself-error"
data-testid="link-input"
data-testid="add-link-button"
data-testid="back-button"
data-testid="continue-button"
data-testid="privacy-policy-footer-link"
data-testid="term-of-service-footer-link"
data-testid="help-footer-button"
data-testid="feedback-footer-button"

Drep explorer page with delegation part:

data-testid="logo-button"
data-testid="dashboard-link"
data-testid="drep-directory-link"
data-testid="governance-actions-link"
data-testid="guides-link"
data-testid="faqs-link"
data-testid="disconnect-button"
data-testid="InfoOutlinedIcon"
data-testid="drep1063u9e7ukcdw3lp4ssgxrufg9ds8wvyq3xmlhruwlw305grfrf0-copy-id-button"
data-testid="automated-voting-options-accordion"

Dashboard:

data-testid="logo-button"
data-testid="dashboard-link"
data-testid="drep-directory-link"
data-testid="governance-actions-link"
data-testid="guides-link"
data-testid="faqs-link"
data-testid="disconnect-button"
data-testid="InfoOutlinedIcon"
data-testid="voting-power-delegation-status"
data-testid="ArrowForwardIosIcon"
data-testid="delegate-learn-more-button"
data-testid="delegate-to-another-drep-button"
data-testid="voting-power-delegation-status"
data-testid="register-button"
data-testid="register-learn-more-button"
data-testid="voting-power-delegation-status"
data-testid="retire-as-sole-voter-button"
data-testid="learn-more-button"
data-testid="voting-power-delegation-status"
data-testid="view-governance-actions-button"
data-testid="learn-more-governance-actions-button"
data-testid="voting-power-delegation-status"
data-testid="propose-governance-actions-button"
data-testid="learn-more-button"
data-testid="privacy-policy-footer-link"
data-testid="term-of-service-footer-link"
data-testid="help-footer-button"
data-testid="feedback-footer-button"
data-testid="delegation-options-dropdown"
data-testid="abstain-from-every-vote-info-button"
data-testid="abstain-from-every-vote-delegate-button"
data-testid="signal-no-confidence-on-every-vote-info-button"
data-testid="signal-no-confidence-on-every-vote-delegate-button"
data-testid="SearchIcon"
data-testid="search-input"
data-testid="filters-button"
data-testid="sort-button"
data-testid="drep1qzw234c0ly8csamxf8hrhfahvzwpllh2ckuzzvl38d22wwxxquu-copy-id-button"
data-testid="drep1qzw234c0ly8csamxf8hrhfahvzwpllh2ckuzzvl38d22wwxxquu-view-details-button"
data-testid="drep1qzw234c0ly8csamxf8hrhfahvzwpllh2ckuzzvl38d22wwxxquu-delegate-button"
data-testid="drep1qy6m9ntcsmq9qex6raha0x904fknajstsy7d3wpquwe67lmmnvh-copy-id-button"
data-testid="drep1qy6m9ntcsmq9qex6raha0x904fknajstsy7d3wpquwe67lmmnvh-view-details-button"
data-testid="drep1qy6m9ntcsmq9qex6raha0x904fknajstsy7d3wpquwe67lmmnvh-delegate-button"
data-testid="drep1q9rg69aquphsns4tl2n75m8n2vemxgjrnrw435cgsh8lu6fyps8-copy-id-button"
data-testid="drep1q9rg69aquphsns4tl2n75m8n2vemxgjrnrw435cgsh8lu6fyps8-view-details-button"
data-testid="drep1q9rg69aquphsns4tl2n75m8n2vemxgjrnrw435cgsh8lu6fyps8-delegate-button"
data-testid="drep1qdmu50p35u8aupu89c00v7fzkplj54yk2m7uzhes2sgmvxdqzsy-copy-id-button"
data-testid="drep1qdmu50p35u8aupu89c00v7fzkplj54yk2m7uzhes2sgmvxdqzsy-view-details-button"
data-testid="drep1qdmu50p35u8aupu89c00v7fzkplj54yk2m7uzhes2sgmvxdqzsy-delegate-button"
data-testid="drep1qjxfjlftmt7gyr50mtmk4mw6d4rl3zrdrfdt964cgvz3gphes2n-copy-id-button"
data-testid="drep1qjxfjlftmt7gyr50mtmk4mw6d4rl3zrdrfdt964cgvz3gphes2n-view-details-button"
data-testid="drep1qjxfjlftmt7gyr50mtmk4mw6d4rl3zrdrfdt964cgvz3gphes2n-delegate-button"
data-testid="drep1qnfx6nqvadycrvcl43xdrlre85npfts7llj0z8nn2ytx2h8nwv2-copy-id-button"
data-testid="drep1qnfx6nqvadycrvcl43xdrlre85npfts7llj0z8nn2ytx2h8nwv2-view-details-button"
data-testid="drep1q4kevzwntlr7724zz5m9t8tnfn35msqauwn8sfrc89rduqmkplx-copy-id-button"
data-testid="drep1q4kevzwntlr7724zz5m9t8tnfn35msqauwn8sfrc89rduqmkplx-view-details-button"
data-testid="drep1q4kevzwntlr7724zz5m9t8tnfn35msqauwn8sfrc89rduqmkplx-delegate-button"
data-testid="drep1qkszl23wfw6kxxuzvsucs07c5ycx40q24r2nl2qmf84k7re5muj-copy-id-button"
data-testid="drep1qkszl23wfw6kxxuzvsucs07c5ycx40q24r2nl2qmf84k7re5muj-view-details-button"
data-testid="drep1qc76sc0stectv3krel2xphk3pw3hdzuc59p639mz4mme6wwudjp-copy-id-button"
data-testid="drep1qc76sc0stectv3krel2xphk3pw3hdzuc59p639mz4mme6wwudjp-view-details-button"
data-testid="drep1qmehvg7vxh9tgwy6rgxenauc3j6hql6nkjrthvcjm457kktpj9k-copy-id-button"
data-testid="drep1qmehvg7vxh9tgwy6rgxenauc3j6hql6nkjrthvcjm457kktpj9k-view-details-button"
data-testid="drep1qmehvg7vxh9tgwy6rgxenauc3j6hql6nkjrthvcjm457kktpj9k-delegate-button"
data-testid="show-more-button"
data-testid="privacy-policy-footer-link"
data-testid="term-of-service-footer-link"
data-testid="help-footer-button"
data-testid="feedback-footer-button"

Gov Actions - details page:
data-testid="logo-button"
data-testid="dashboard-link"
data-testid="drep-directory-link"
data-testid="governance-actions-link"
data-testid="guides-link"
data-testid="faqs-link"
data-testid="disconnect-button"
data-testid="InfoOutlinedIcon"
data-testid="back-to-list-link"
data-testid="governance-action-details-card"
data-testid="governance-action-details-card-header"
data-testid="share-button"
data-testid="NoConfidence-type"
data-testid="submission-date"
data-testid="InfoOutlinedIcon"
data-testid="expiry-date"
data-testid="InfoOutlinedIcon"
data-testid="external-modal-button"
data-testid="d2f4bea73f954f5f9104d0aedeafc180336f63fcb19671646b9bbc0639fb906d#0-id"
data-testid="copy-button"
data-testid="yes-radio"
data-testid="no-radio"
data-testid="abstain-radio"
data-testid="show-votes-button"
data-testid="provide-context-button"
data-testid="vote-button"
data-testid="privacy-policy-footer-link"
data-testid="term-of-service-footer-link"
data-testid="help-footer-button"
data-testid="feedback-footer-button"

Retirement:

data-testid="Back-to-dashboard-link"
data-testid="ArrowBackIosIcon"
data-testid="back-button"
data-testid="continue-retirement-button"
data-testid="privacy-policy-footer-link"
data-testid="term-of-service-footer-link"
data-testid="help-footer-button"
data-testid="feedback-footer-button"

@SandraRodziewicz
Copy link

Most of the test Ids are there, the few missing are delegated to separate task to be fixed later #1038

Ready for staging

@NabinKawan
Copy link
Contributor Author

Reopening this ticket again

Test-ids are not consistent. They are changing link

Please adjust test-ids acc. to the test.

@NabinKawan NabinKawan reopened this May 28, 2024
@NabinKawan NabinKawan moved this from In staging to To do in Govtool all May 28, 2024
@Sworzen1 Sworzen1 moved this from To do to In review in Govtool all May 29, 2024
@Sworzen1 Sworzen1 moved this from In review to In QA in Govtool all May 29, 2024
@pmbinapps
Copy link

OK Registration page ids are:

Image

Image

OK on Storage page Submit is as register-button

Image

OK Delegation page

Image

@pmbinapps
Copy link

Regarding comment, these current ids that set on DRep registration, update should enable automation:

Image

@pmbinapps pmbinapps moved this from In QA to In staging in Govtool all Jun 10, 2024
@MSzalowski MSzalowski moved this from In staging to Done in Govtool all Jun 13, 2024
@kneerose
Copy link
Contributor

kneerose commented Aug 8, 2024

I have listed the remaining missing test IDs on another ticket. This can be closed now. CC: @bosko-m

@bosko-m
Copy link
Contributor

bosko-m commented Aug 9, 2024

Closing as per the comment above.

@bosko-m bosko-m closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

9 participants