Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard, DRep metadata validation: after Retirement, and when a user is a Direct Voter - DRep metadata are shown as missing #1254

Closed
pmbinapps opened this issue Jun 11, 2024 · 5 comments
Labels
🐛 Bug Something isn't working

Comments

@pmbinapps
Copy link

pmbinapps commented Jun 11, 2024

To reproduce:

I scenario:

  1. Register as Drep
  2. Retire

Image

Image

Compare with Jam Recording

II Scenario:
Use two users

  1. 1st one registers as Direct Voter
  2. 2nd user browse DReps - when the first user card is show in title is show Data missing:

Image

@pmbinapps pmbinapps self-assigned this Jun 11, 2024
@pmbinapps pmbinapps converted this from a draft issue Jun 11, 2024
@pmbinapps pmbinapps added the 🐛 Bug Something isn't working label Jun 11, 2024
@pmbinapps pmbinapps changed the title Dashboard - DRep metadata validation - after Retirement - DRep metadata are show as missing Dashboard, DRep metadata validation: after Retirement, and when a user is a Direct Voter - DRep metadata are shown as missing Jun 11, 2024
@MSzalowski MSzalowski moved this to In progress in Govtool all Jun 12, 2024
@MSzalowski
Copy link
Contributor

After DRep's retirement, we lose track of its metadata (check the url field):

Zrzut ekranu z 2024-06-12 10-14-56

However, it seems to be a bug to display Data Missing on delegation card for the retired DRep.

@m-i-k-e Should we display the DRep instead of Data Missing on the delegation card, when delegation is set to the retired DRep?

@MSzalowski MSzalowski assigned m-i-k-e and MSzalowski and unassigned MSzalowski and pmbinapps Jun 12, 2024
@MSzalowski MSzalowski moved this from In progress to To do in Govtool all Jun 12, 2024
@MSzalowski MSzalowski moved this from To do to In QA in Govtool all Jun 12, 2024
@pmbinapps
Copy link
Author

pmbinapps commented Jun 12, 2024

OK on Dashboard

NOT OK in details page reached with direct link. - still Data missing error:

Image

NOT OK - drep not found on in DRep explorer as Retired DRep (was - before it become DirectVoter)

Image

Image

@pmbinapps pmbinapps moved this from In QA to To do in Govtool all Jun 12, 2024
@MSzalowski
Copy link
Contributor

MSzalowski commented Jun 13, 2024

I would leave this as a known issue and pass it to staging, what do you think @m-i-k-e?

@bosko-m
Copy link
Contributor

bosko-m commented Jul 18, 2024

@MSzalowski Is this related to CIP-119?

@MSzalowski
Copy link
Contributor

It is related to CIP-119, we don't have the metadata validation standardized for the DReps yet

@Ryun1 Ryun1 closed this as completed Aug 7, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Govtool all Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

5 participants