Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Missing Test IDs for DRep Info Page #1863

Closed
kneerose opened this issue Aug 29, 2024 · 0 comments · Fixed by #1886
Closed

🐛 Missing Test IDs for DRep Info Page #1863

kneerose opened this issue Aug 29, 2024 · 0 comments · Fixed by #1886
Assignees
Labels
🐛 Bug Something isn't working Other area

Comments

@kneerose
Copy link
Contributor

Area

Other

Domain

dev-sanchogov.tools

Which wallet were you using?

No response

Context

Test IDs are missing on the new components of the DRep Info page. The missing test IDs are as follows:

  • objective-content
  • motivation-content
  • qualification-content

Additionally, the Test ID for the payment address is incorrect:
Current Test ID: copy-drep-id-button
Suggested Test ID: payment-address or copy-payment-address-button

Steps to reproduce

  1. Register as a dRep.
  2. Click on View Your DRep Details.
  3. Observe the Test IDs mentioned above.

Actual behavior

  • Test IDs for objective-content, motivation-content, and qualification-content are missing.

image

image

image

  • The Test ID for the payment address is incorrectly labeled as copy-drep-id-button.

image

Expected behavior

  • The page should include appropriate Test IDs for all display text and links, particularly for the new components.
  • The Test ID for the payment address should be corrected to something more descriptive, like payment-address or copy-payment-address-button.
    Note: Please ensure that appropriate Test IDs are added whenever a new component is introduced.
@kneerose kneerose added the 🐛 Bug Something isn't working label Aug 29, 2024
@bosko-m bosko-m moved this to To do in Govtool all Aug 30, 2024
@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Aug 30, 2024
@MSzalowski MSzalowski assigned MSzalowski and unassigned jdyczka Aug 30, 2024
@MSzalowski MSzalowski linked a pull request Aug 30, 2024 that will close this issue
5 tasks
@MSzalowski MSzalowski moved this from In progress to In review in Govtool all Aug 30, 2024
MSzalowski added a commit that referenced this issue Aug 30, 2024
…for-drep-info-page

fix(#1863): add missing DRep Details test IDs
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working Other area
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants