Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Copy governance action ID shows and copied incorrect ID #1866

Closed
Ryun1 opened this issue Aug 29, 2024 · 0 comments · Fixed by #1885
Closed

🐛 Copy governance action ID shows and copied incorrect ID #1866

Ryun1 opened this issue Aug 29, 2024 · 0 comments · Fixed by #1885
Assignees
@MSzalowski
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar
Milestone
🥾 Needed for Boot...

Comments

@Ryun1
Copy link
Member

Ryun1 commented Aug 29, 2024

Area

Voting Pillar

Domain

preview.gov.tools

Which wallet were you using?

No response

Context

Going to https://sanchogov.tools/governance_actions/d9a23345e4d3b063e3161fc174c19b35b6bd71ef62d1b6d92e516c9c27364f3f#0

the ID should be d9a23345e4d3b063e3161fc174c19b35b6bd71ef62d1b6d92e516c9c27364f3f#0

But the copy button
shows;

  • 0d9a23345e4d3b063e3161fc174c19b35b6bd71ef62d1b6d92e516c9c27364f3f

it puts the index at the front of the hex encoded transaction
image

Steps to reproduce

https://sanchogov.tools/governance_actions/d9a23345e4d3b063e3161fc174c19b35b6bd71ef62d1b6d92e516c9c27364f3f#0

Actual behavior

But the copy button shows and copies

  • 0d9a23345e4d3b063e3161fc174c19b35b6bd71ef62d1b6d92e516c9c27364f3f

Expected behavior

But the copy button shows and copies

  • d9a23345e4d3b063e3161fc174c19b35b6bd71ef62d1b6d92e516c9c27364f3f#0
@Ryun1 Ryun1 added the 🐛 Bug Something isn't working label Aug 29, 2024
@Ryun1 Ryun1 moved this to To do in Govtool all Aug 29, 2024
@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Aug 30, 2024
MSzalowski added a commit that referenced this issue Aug 30, 2024
@MSzalowski
fix(#1866): fir formatting governance action id
af1d29d
MSzalowski added a commit that referenced this issue Aug 30, 2024
@MSzalowski
fix(#1866): fix formatting governance action id
e1366e8
@MSzalowski MSzalowski mentioned this issue Aug 30, 2024
Merged
5 tasks
@MSzalowski MSzalowski linked a pull request Aug 30, 2024 that will close this issue
fix(#1866): fix formatting governance action id #1885
Merged
5 tasks
@MSzalowski MSzalowski moved this from In progress to In review in Govtool all Aug 30, 2024
MSzalowski added a commit that referenced this issue Aug 30, 2024
@MSzalowski
fix(#1866): fix wrong test condition
556d6fc
MSzalowski added a commit that referenced this issue Aug 30, 2024
@MSzalowski
Merge pull request #1885 from IntersectMBO/fix/1866-copy-governance-a…
2af5579 
…ction-id-shows-and-copied-incorrect-id

fix(#1866): fix formatting governance action id
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSzalowski MSzalowski

Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar
Projects
Governance Tools Community Backlog
Status: Done
Govtool all
Status: Done
Milestone
🥾 Needed for Bootstrapping / Mainnet
Development

Successfully merging a pull request may close this issue.

fix(#1866): fix formatting governance action id IntersectMBO/govtool
4 participants
@jdyczka @MSzalowski @Ryun1 @bosko-m