Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 DRep metdata validation #1894

Closed
Ryun1 opened this issue Sep 2, 2024 · 4 comments · Fixed by #1915 or #1920
Closed

🐛 DRep metdata validation #1894

Ryun1 opened this issue Sep 2, 2024 · 4 comments · Fixed by #1915 or #1920

Comments

@Ryun1
Copy link
Member

Ryun1 commented Sep 2, 2024

Area

Voting Pillar

Domain

gov.tools

Which wallet were you using?

No response

Context

  • Data Not Verifiable error for nearly all DRep registrations
  • Seems like the hash check is not working properly
  • Even when the metadata files look good and should be valid

Steps to reproduce

  1. look at DRep directory and look at detailed view of DReps

Actual behavior

  • nearly all DReps with correct metadata get the Data Not Verifiable error

Expected behavior

  • DRep metadata is rendered without error
@Ryun1
Copy link
Member Author

Ryun1 commented Sep 2, 2024

might help to bump the DBSync version to the latest

@MSzalowski MSzalowski moved this to In progress in Govtool all Sep 2, 2024
@MSzalowski MSzalowski self-assigned this Sep 2, 2024
@MSzalowski
Copy link
Contributor

I've tested on Sancho with sorting by Registration date:

Nagranie.z.ekranu.2024-09-2.o.10.27.26.mov

After checking the logs in the metadata validation service, for cases where the validation failed - I could not find any error either.

I would have to have access to a specific case to be able to properly verify this issue.

@MSzalowski MSzalowski moved this from In progress to To do in Govtool all Sep 2, 2024
@MSzalowski
Copy link
Contributor

@Ryun1 Could you please provide a link for the specific DRep for which the error occurs?

@gitmachtl
Copy link

gitmachtl commented Sep 2, 2024

@Ryun1 Could you please provide a link for the specific DRep for which the error occurs?

you can test mine on preview if you like, also on mainnet:
drep1mkmnzmtlflcadyyy7g6ju3sn9ppcrut5wn73x00mfwmw642g5qy

dbsync via koios says valid=true

can register it also on sancho if needed

@MSzalowski MSzalowski linked a pull request Sep 3, 2024 that will close this issue
5 tasks
MSzalowski added a commit that referenced this issue Sep 3, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Govtool all Sep 3, 2024
@MSzalowski MSzalowski linked a pull request Sep 3, 2024 that will close this issue
5 tasks
@MSzalowski MSzalowski reopened this Sep 3, 2024
@MSzalowski MSzalowski moved this from Done to In progress in Govtool all Sep 3, 2024
@MSzalowski MSzalowski moved this from Done to In Progress in Governance Tools Community Backlog Sep 3, 2024
@MSzalowski MSzalowski moved this from In progress to In review in Govtool all Sep 3, 2024
MSzalowski added a commit that referenced this issue Sep 3, 2024
…dation

fix(#1894): make response of the metadata restricted to be raw text
@github-project-automation github-project-automation bot moved this from In Progress to Done in Governance Tools Community Backlog Sep 3, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment