Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Mainnet Ada holder voting power incorrect #1923

Closed
Ryun1 opened this issue Sep 3, 2024 · 3 comments
Closed

🐛 Mainnet Ada holder voting power incorrect #1923

Ryun1 opened this issue Sep 3, 2024 · 3 comments
Assignees
@jdyczka @spannercode @aaboyle878
Labels
🐛 Bug Something isn't working 🎁 Wrapper
Milestone
🥾 Needed for Boot...

Comments

@Ryun1
Copy link
Member

Ryun1 commented Sep 3, 2024

Area

Wrapper

Domain

gov.tools

Which wallet were you using?

No response

Context

  • On mainnnet instance
  • Ada holder voting power seems to be showing total amount of ADA in and out of the wallet
  • Using this wallet
  • the balance is around 50 ADA, but GovTool is showing over 2000 ADA
  • stake credential: e1130796e23f5c56594f50ace2c3240923219fc69ee2cb6e2c8facec68
    image

Steps to reproduce

  1. connect a minnet wallet to govtool

Actual behavior

  • Incorrect voting power is shown

Expected behavior

  • Correct voting power is shown
@Ryun1 Ryun1 added the 🐛 Bug Something isn't working label Sep 3, 2024
@Ryun1 Ryun1 moved this to To do in Govtool all Sep 3, 2024
@Ryun1
Copy link
Member Author

Ryun1 commented Sep 3, 2024 •
edited
Loading

Probably this one is the issue

It is summing all UTxOs ever rather than just current ones

jdyczka pushed a commit that referenced this issue Sep 5, 2024
@j-dyczka
[#1923] temporary fix
59f7f26
jdyczka pushed a commit that referenced this issue Sep 5, 2024
@j-dyczka
[#1923] temporary fix
413745a
jdyczka added a commit that referenced this issue Sep 5, 2024
@jdyczka
Merge pull request #1948 from IntersectMBO/fix/1923-voting-power-temp…
29770c2 
…orary-fix

[#1923] temporary fix
@bosko-m bosko-m assigned jdyczka and aaboyle878 and unassigned Ryun1 Sep 6, 2024
@Ryun1
Copy link
Member Author

Ryun1 commented Sep 10, 2024

  • Current mainnet voting power much closer to being correct - new ticket for final discrepencies
  • @jdyczka we can add back in this feature

@Ryun1
Copy link
Member Author

Ryun1 commented Sep 10, 2024

Carry on discussion here:

jdyczka pushed a commit that referenced this issue Sep 11, 2024
@j-dyczka
[#1923] display value of Ada holder voting power
afa5707
jdyczka pushed a commit that referenced this issue Sep 11, 2024
@j-dyczka
[#1923] display value of Ada holder voting power
b24b277
jdyczka pushed a commit that referenced this issue Sep 12, 2024
@j-dyczka
[#1923] display value of Ada holder voting power
7cc24fd
jdyczka added a commit that referenced this issue Sep 12, 2024
@jdyczka
Merge pull request #2009 from IntersectMBO/fix/1923-display-voting-po…
892238a 
…wer-value

[#1923] display value of Ada holder voting power
@Ryun1 Ryun1 closed this as completed Sep 12, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Govtool all Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdyczka jdyczka

@spannercode spannercode

@aaboyle878 aaboyle878

Labels
🐛 Bug Something isn't working 🎁 Wrapper
Projects
Governance Tools Community Backlog
Status: Done
Govtool all
Status: Done
Milestone
🥾 Needed for Bootstrapping / Mainnet
Development

No branches or pull requests
5 participants
@jdyczka @MSzalowski @Ryun1 @spannercode @aaboyle878