Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Incorrect date of voting #1925

Closed
spannercode opened this issue Sep 4, 2024 · 1 comment
Closed

🐛 Incorrect date of voting #1925

spannercode opened this issue Sep 4, 2024 · 1 comment
Assignees
@jdyczka
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar
Milestone
🥾 Needed for Boot...

Comments

@spannercode
Copy link
Contributor

spannercode commented Sep 4, 2024 •
edited
Loading

Area

Voting Pillar

Domain

preview.gov.tools

Which wallet were you using?

Eternal Beta

Context

The date shown when the DRep voted on a gov action proposal is shown as the proposal submission time. It should reflect the correct date when the user has voted.

Steps to reproduce

  1. As a DRep, find a gov action proposal to vote. For eg.
    https://preview.gov.tools/connected/governance_actions/699b989055cb4ea7501e9028df24a48fa256969ef7d82be757b7d7f635d5730b#0
  2. Vote on the proposal and wait until the transaction is complete.
  3. View the proposal to see your vote. On the right side of the details page, find the text indicating when you voted on the proposal.

Actual behavior

The date of voting is shown as the proposal submission date.
Screenshot 2024-09-04 at 07 55 25

Expected behavior

The voting date should reflect the actual voting date.
@spannercode spannercode added the 🐛 Bug Something isn't working label Sep 4, 2024
@jdyczka jdyczka moved this to In progress in Govtool all Sep 4, 2024
@jdyczka jdyczka self-assigned this Sep 4, 2024
jdyczka pushed a commit that referenced this issue Sep 4, 2024
@j-dyczka
[#1925] query time from vote tx instead of gov action tx
f3dfafd
jdyczka pushed a commit that referenced this issue Sep 4, 2024
@j-dyczka
[#1925] query time from vote tx instead of gov action tx
16b7938
@jdyczka jdyczka mentioned this issue Sep 4, 2024
Merged
5 tasks
@jdyczka jdyczka moved this from In progress to In review in Govtool all Sep 4, 2024
jdyczka pushed a commit that referenced this issue Sep 4, 2024
@j-dyczka
[#1925] query time from vote tx instead of gov action tx
4cc7f54
jdyczka added a commit that referenced this issue Sep 4, 2024
@jdyczka
Merge pull request #1931 from IntersectMBO/fix/1925-incorrect-voting-…
5ada165 
…date

[#1925] query time from vote tx instead of gov action tx
@jdyczka jdyczka mentioned this issue Sep 4, 2024
Merged
@bosko-m bosko-m moved this from In review to In staging in Govtool all Sep 4, 2024
@bosko-m bosko-m removed their assignment Sep 4, 2024
@bosko-m
Copy link
Contributor

bosko-m commented Sep 4, 2024

Verified on Preview, closing.

@bosko-m bosko-m closed this as completed Sep 4, 2024
@github-project-automation github-project-automation bot moved this from In staging to Done in Govtool all Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdyczka jdyczka

Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar
Projects
Governance Tools Community Backlog
Status: Done
Govtool all
Status: Done
Milestone
🥾 Needed for Bootstrapping / Mainnet
Development

No branches or pull requests
3 participants
@jdyczka @spannercode @bosko-m