Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 CIP 129 support on GovTool (?) #2183

Closed
spannercode opened this issue Oct 18, 2024 · 3 comments
Closed

💡 CIP 129 support on GovTool (?) #2183

spannercode opened this issue Oct 18, 2024 · 3 comments
Assignees
@MSzalowski
Labels
❗️ Blocked 💡 Feature idea Other area ❔ Question Further information is requested
Milestone
🏛 Needed for Full...

Comments

@spannercode
Copy link
Contributor

Area

Other

Is there new design needed?

Yes

What?

Currently, CIP 129 governance identifiers are not supported on GovTool. The following tools currently supports the CIP (not sure if it is up-to-date).

Screenshot 2024-10-18 at 15 21 02

Why?

So that GovTool remains compatible with the rest of the ecosystem tooling.

How?

Refer to the implementation plan of the CIP
https://github.com/StricaHQ/CIPs/blob/gov-identifiers/CIP-0129/README.md#implementation-plan

(Optional) User Story with acceptance criteria

As a user of GovTool wallet connected or not,
When I use CIP129 governance identifiers for DRep and Governance actions on search or URLs
Then I see the appropriate governance details.
@bosko-m bosko-m moved this to To do in Govtool all Nov 3, 2024
@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Nov 5, 2024
@MSzalowski
Copy link
Contributor

@m-i-k-e Should we display both governance action identifiers (default, and CIP-129) or just CIP-129?

MSzalowski added a commit that referenced this issue Nov 6, 2024
@MSzalowski
feat(#2183): add support for CIP-129 governance identifiers
d22bf6a
@MSzalowski MSzalowski mentioned this issue Nov 6, 2024
Merged
5 tasks
@MSzalowski MSzalowski moved this from In progress to In review in Govtool all Nov 6, 2024
@MSzalowski MSzalowski added ❔ Question Further information is requested ❗️ Blocked labels Nov 6, 2024
@MSzalowski
Copy link
Contributor

Pull request is ready and will be merged once this question is answered

MSzalowski added a commit that referenced this issue Nov 6, 2024
@MSzalowski
feat(#2183): add support for CIP-129 governance identifiers
4016076
@Ryun1
Copy link
Member

Ryun1 commented Nov 6, 2024

@MSzalowski

yes, both should be shown to users

MSzalowski added a commit that referenced this issue Nov 7, 2024
@MSzalowski
Merge pull request #2341 from IntersectMBO/fix/2183--cip-129-support-…
9913448 
…on-govtool

feat(#2183): add support for CIP-129 governance identifiers
@MSzalowski MSzalowski moved this from In review to Done in Govtool all Nov 7, 2024
@bosko-m bosko-m closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSzalowski MSzalowski

Labels
❗️ Blocked 💡 Feature idea Other area ❔ Question Further information is requested
Projects
Governance Tools Community Backlog
Status: Done
Govtool all
Status: Done
Milestone
🏛 Needed for Full governance / Mainnet
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/fi/x2183--cip-129-support-on-govtool IntersectMBO/govtool
4 participants
@MSzalowski @Ryun1 @spannercode @bosko-m