Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Protocol parameter change GA is not displayed correctly #2191

Closed
bosko-m opened this issue Oct 22, 2024 · 2 comments · Fixed by #2193
Closed

🐛 Protocol parameter change GA is not displayed correctly #2191

bosko-m opened this issue Oct 22, 2024 · 2 comments · Fixed by #2193
Assignees
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar

Comments

@bosko-m
Copy link
Contributor

bosko-m commented Oct 22, 2024

Area

Voting Pillar

Domain

sanchogov.tools

Which wallet were you using?

Eternl v1.12.16.0

Context

I was trying to observe newly submitted protocol parameter change GA on Sancho to check whether all changes are represented properly and it seems incomplete.

Steps to reproduce

  1. Got to sanchogov.tools
  2. Connect the wallet
  3. Go to specific GA - https://sanchogov.tools/connected/governance_actions/5b06976ce88d1cc4a7a5cc2478e418c1bb18cd5538527d963a931593f021f533#0
  4. Check reasoning and parameters tabs

Actual behavior

  1. In parameters tab there is only one line of changes

Expected behavior

  1. In parameters tab there there should be more than one line of changes
@bosko-m
Copy link
Contributor Author

bosko-m commented Oct 22, 2024

FYI @Ryun1

@Ryun1
Copy link
Member

Ryun1 commented Oct 22, 2024

This parameter change is ONLY adding new parameters and not changing any existing values.

This issue seems to be caused, because we are not comparing the cost model tables, we are only comparing the param_proposal table, we should be joining this table with costmodel

@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Oct 22, 2024
@MSzalowski MSzalowski linked a pull request Oct 22, 2024 that will close this issue
5 tasks
@MSzalowski MSzalowski moved this from In progress to In review in Govtool all Oct 22, 2024
MSzalowski added a commit that referenced this issue Oct 24, 2024
…r-change-ga-is-not-displayed-correctly

fix(#2191): protocol parameter change ga is not displayed correctly
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Oct 24, 2024
MSzalowski added a commit that referenced this issue Oct 24, 2024
fix(#2191): protocol parameter change ga is not displayed correctly
MSzalowski added a commit that referenced this issue Oct 24, 2024
fix(#2191): protocol parameter change ga is not displayed correctly
MSzalowski added a commit that referenced this issue Oct 24, 2024
fix(#2191): protocol parameter change ga is not displayed correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants