-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Protocol parameter change GA is not displayed correctly #2191
Labels
Comments
FYI @Ryun1 |
This parameter change is ONLY adding new parameters and not changing any existing values. This issue seems to be caused, because we are not comparing the cost model tables, we are only comparing the param_proposal table, we should be joining this table with costmodel |
MSzalowski
added a commit
that referenced
this issue
Oct 22, 2024
5 tasks
5 tasks
MSzalowski
added a commit
that referenced
this issue
Oct 22, 2024
MSzalowski
added a commit
that referenced
this issue
Oct 24, 2024
MSzalowski
added a commit
that referenced
this issue
Oct 24, 2024
…r-change-ga-is-not-displayed-correctly fix(#2191): protocol parameter change ga is not displayed correctly
MSzalowski
added a commit
that referenced
this issue
Oct 24, 2024
fix(#2191): protocol parameter change ga is not displayed correctly
MSzalowski
added a commit
that referenced
this issue
Oct 24, 2024
fix(#2191): protocol parameter change ga is not displayed correctly
MSzalowski
added a commit
that referenced
this issue
Oct 24, 2024
fix(#2191): protocol parameter change ga is not displayed correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Area
Voting Pillar
Domain
sanchogov.tools
Which wallet were you using?
Eternl v1.12.16.0
Context
I was trying to observe newly submitted protocol parameter change GA on Sancho to check whether all changes are represented properly and it seems incomplete.
Steps to reproduce
Actual behavior
Expected behavior
The text was updated successfully, but these errors were encountered: