Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance Action metadata builder error handling #380

Closed
MSzalowski opened this issue Mar 4, 2024 · 5 comments
Closed

Governance Action metadata builder error handling #380

MSzalowski opened this issue Mar 4, 2024 · 5 comments
Assignees
Labels
🖥 Frontend Frontend related

Comments

@MSzalowski
Copy link
Contributor

Why

As someone who wants to input background information about a governance action

I want the UI to warn me when there is an error

So that I do not create something unusable

What

Given that I have input something into the metadata builder that does not comply with CIP-108 or is not in the correct format

When I attempt to proceed to the next page

Then I will be prevented from doing so and be told why and where there is an error

Link to figma

DoD

There is error handling to ensure that the information being entered into the metadata builder is in a format that can be developed into metadata.

@MSzalowski MSzalowski added the 🖥 Frontend Frontend related label Mar 4, 2024
@MSzalowski MSzalowski self-assigned this Mar 8, 2024
@MSzalowski
Copy link
Contributor Author

Done with #445

@pmbinapps
Copy link

@MSzalowski Valid public available Info - file Cannot be found, error message 'The URL You Entered Cannot Be Found'

Image

@pmbinapps pmbinapps self-assigned this Mar 14, 2024
@MSzalowski
Copy link
Contributor Author

It is related to #30 as it introduces the limitation of allowed domains - I am investigating the potential solution

@MSzalowski
Copy link
Contributor Author

Closed with #480

@pmbinapps
Copy link

OK when:

  • valid URL and file matches
  • not reachable content detected
  • not matching metadata file detected fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖥 Frontend Frontend related
Projects
Status: Done
Development

No branches or pull requests

2 participants