Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifying Toggle Maintenance workflow configuration #444

Closed
2 tasks
placek opened this issue Mar 11, 2024 · 0 comments · Fixed by #486
Closed
2 tasks

Simplifying Toggle Maintenance workflow configuration #444

placek opened this issue Mar 11, 2024 · 0 comments · Fixed by #486
Assignees
@placek @pmbinapps
Labels
🏗 Infrastructure 🔩 Tech debt
Milestone
Infrastructure ma...

Comments

@placek
Copy link
Contributor

placek commented Mar 11, 2024

As a developer,

I want to simplify the toggle maintenance workflow configuration

to easily manage and update the workflow setup.

Summary:

The toggle maintenance workflow configuration needs to be simplified by removing the domain ENVs setup and make arguments, as they are redundant due to make's ability to resolve domain ENVs and set default arguments from environment variables.

Acceptance criteria:

  • Remove domain ENVs setup from the toggle maintenance workflow configuration.
  • Eliminate make arguments from the configuration, as they can be set by default using environment variables.
@placek placek self-assigned this Mar 11, 2024
placek added a commit that referenced this issue Mar 15, 2024
@placek
[#444] Refactor maintenance mode workflow
fd9ccbd 
To streamline the toggle maintenance workflow configuration, this commit
simplifies the setup by removing the domain ENVs configuration and make
arguments. These components are deemed unnecessary as make can now
resolve domain variables and set default arguments from environment
variables more efficiently.

Changes:
- Edited the workflow file: `.github/workflows/toggle-maintenance.yml`
  to adjust the name of the maintenance workflow and default values for
  maintenance mode.
- Updated the Makefile in `scripts/govtool` by modifying the
  toggle-maintenance target to include docker-login and simplified the
  maintenance mode condition to use "enabled" instead of "enable" for
  consistency.
@placek placek mentioned this issue Mar 15, 2024
Merged
@placek placek linked a pull request Mar 15, 2024 that will close this issue
[#444] Simplifying Toggle Maintenance workflow configuration #486
Merged
placek added a commit that referenced this issue Mar 18, 2024
@placek
[#444] Refactor maintenance mode workflow
89f6298 
To streamline the toggle maintenance workflow configuration, this commit
simplifies the setup by removing the domain ENVs configuration and make
arguments. These components are deemed unnecessary as make can now
resolve domain variables and set default arguments from environment
variables more efficiently.

Changes:
- Edited the workflow file: `.github/workflows/toggle-maintenance.yml`
  to adjust the name of the maintenance workflow and default values for
  maintenance mode.
- Updated the Makefile in `scripts/govtool` by modifying the
  toggle-maintenance target to include docker-login and simplified the
  maintenance mode condition to use "enabled" instead of "enable" for
  consistency.
placek added a commit that referenced this issue Mar 18, 2024
@placek
Merge pull request #486 from IntersectMBO/chore/444-simplifying-toggl…
b647323 
…e-maintenance-workflow-configuration

[#444] Simplifying Toggle Maintenance workflow configuration
@pmbinapps pmbinapps mentioned this issue Mar 20, 2024
Merged
@pmbinapps pmbinapps self-assigned this Mar 22, 2024
@l-br1 l-br1 added this to Govtool all Apr 2, 2024
@MSzalowski MSzalowski moved this to In staging in Govtool all Apr 8, 2024
@MSzalowski MSzalowski moved this from In staging to Blocked in Govtool all Apr 8, 2024
@bosko-m bosko-m moved this from Blocked to Done in Govtool all Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@placek placek

@pmbinapps pmbinapps

Labels
🏗 Infrastructure 🔩 Tech debt
Projects
Govtool all
Status: Done
Milestone
Infrastructure management (DevOps)
Development

Successfully merging a pull request may close this issue.

[#444] Simplifying Toggle Maintenance workflow configuration IntersectMBO/govtool
2 participants
@placek @pmbinapps