Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BT] GA Submit - where there is not enough founds - no info modal view is shown (INFO: DESING READY, TODO) #509

Closed
pmbinapps opened this issue Mar 19, 2024 · 9 comments · Fixed by #1156
Labels
🐛 Bug Something isn't working

Comments

@pmbinapps
Copy link
Contributor

During submition on Info GA - occurred that balance on account was below 1000 A, but no error dialog informing about this was show.

To reproduce, with balance lower than 1000 Ada try to submit a GA..

Image

@MSzalowski
Copy link
Contributor

@m-i-k-e @Thomas-Upfield What should we display in such a scenario?

@m-i-k-e
Copy link

m-i-k-e commented Mar 21, 2024

@MSzalowski As I understand it, you need 1,000 ADA to submit a GA, and there was 'insufficient balance' in the user's wallet?

We need an error message for this.

I will get it done in Figma, and attach the Figma link here.

@m-i-k-e
Copy link

m-i-k-e commented Mar 21, 2024

So we will create a modal error box after the very first click (in image here)

I will return and attach the link when it's done.

image

@Sworzen1
Copy link
Contributor

IMO no UX on the frontend side, after submitting we should display a modal error but we only do Sentry.captureException(error);

@l-br1 l-br1 added this to Govtool all Apr 2, 2024
@l-br1 l-br1 moved this to To do in Govtool all Apr 2, 2024
@l-br1 l-br1 added the 🐛 Bug Something isn't working label Apr 2, 2024
@MSzalowski MSzalowski moved this from To do to Backlog in Govtool all Apr 5, 2024
@l-br1 l-br1 moved this from Backlog to To do in Govtool all Apr 8, 2024
@m-i-k-e m-i-k-e assigned MSzalowski and unassigned m-i-k-e Apr 8, 2024
@pmbinapps pmbinapps changed the title GA Submit - where there is not enough founds - no info modal view is shown [BT] GA Submit - where there is not enough founds - no info modal view is shown (INFO: DESING READY, TODO) Apr 9, 2024
@MSzalowski MSzalowski assigned MSzalowski and unassigned MSzalowski Apr 10, 2024
@JanJaroszczak JanJaroszczak self-assigned this Apr 17, 2024
@JanJaroszczak JanJaroszczak moved this from To do to In progress in Govtool all Apr 17, 2024
@JanJaroszczak JanJaroszczak moved this from In progress to In review in Govtool all Apr 18, 2024
JanJaroszczak added a commit that referenced this issue Apr 18, 2024
JanJaroszczak added a commit that referenced this issue Apr 18, 2024
@m-i-k-e
Copy link

m-i-k-e commented May 13, 2024

The error in the screenshot above is not correct. This is the screen for this error: https://www.figma.com/design/mJTBiUofLfb74Xc3W2U59o/Voltaire---GOV-TOOL?m=auto&node-id=7079%3A81357&t=VewrRakbrZccwD9V-1

@pmbinapps
Copy link
Contributor Author

Still NOT OK - previous modal was wrongly assumed as expected, below is expected one:

Figma design

Image

Currently is shown:

Image

@pmbinapps pmbinapps moved this from In QA to To do in Govtool all May 15, 2024
@pmbinapps pmbinapps assigned Sworzen1 and unassigned pmbinapps May 15, 2024
@Sworzen1 Sworzen1 moved this from To do to In progress in Govtool all Jun 4, 2024
@Sworzen1 Sworzen1 moved this from In progress to In review in Govtool all Jun 4, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Jun 5, 2024
@Sworzen1 Sworzen1 moved this from Done to In QA in Govtool all Jun 5, 2024
@pmbinapps
Copy link
Contributor Author

OK NOW on dev:

Recheck on test-sancho.

Image

@pmbinapps pmbinapps reopened this Jun 5, 2024
@pmbinapps pmbinapps assigned pmbinapps and unassigned Sworzen1 Jun 5, 2024
@pmbinapps pmbinapps moved this from In QA to In staging in Govtool all Jun 10, 2024
@MSzalowski MSzalowski moved this from In staging to Done in Govtool all Jun 13, 2024
@Ryun1 Ryun1 closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Archived in project
9 participants