Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA Search - Voted on - Search is not working #640

Closed
pmbinapps opened this issue Apr 5, 2024 · 4 comments · Fixed by #713
Closed

GA Search - Voted on - Search is not working #640

pmbinapps opened this issue Apr 5, 2024 · 4 comments · Fixed by #713
Labels
⚙ Backend 🐛 Bug Something isn't working

Comments

@pmbinapps
Copy link

pmbinapps commented Apr 5, 2024

Noting is found from metadata in Voted on view;

Jam recording here

Related to #604 - on Gov actions search not retaining filter nor order

@pmbinapps pmbinapps self-assigned this Apr 5, 2024
@pmbinapps pmbinapps added the 🐛 Bug Something isn't working label Apr 5, 2024
@MSzalowski MSzalowski added 🖥 Frontend Frontend related 🔍 Needs triage ⚙ Backend and removed 🖥 Frontend Frontend related labels Apr 9, 2024
@MSzalowski
Copy link
Contributor

That issue requires frontend and backend implementation to be fixed.
We can treat this issue as a backend task.

@jankun4
To do on the backend side:
As source of this data is delivered by different endpoint than /proposal/list

To do:

Provide exactly the same query parameters as on the /proposal/list to /drep/getVotes
Example of /proposal/list endpoint parameters from the dev swagger: https://dev-sanchonet.govtool.byron.network/api/swagger-ui/#/default/get_proposal_list

@MSzalowski MSzalowski moved this to To do in Govtool all Apr 9, 2024
@MSzalowski
Copy link
Contributor

Frontend task that covers that issue: #674

@pmbinapps
Copy link
Author

Related to #650

@pmbinapps
Copy link
Author

OK NOW Search on Voting on was added.
Jam recording, here

Note: After a voting to a GA, there is a lag in update of 'To Vote' view - compare with 0:20s - 0:30s moment of above recording. Later on cards are updated correctly

@pmbinapps pmbinapps moved this from In QA to In staging in Govtool all Apr 29, 2024
@bosko-m bosko-m moved this from In staging to Done in Govtool all Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙ Backend 🐛 Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants