Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items on Abstain and No Confidence dropdown implemented different than the design in Figma #918

Closed
m-i-k-e opened this issue May 1, 2024 · 6 comments · Fixed by #963
Closed
Assignees
Labels
🐛 Bug Something isn't working

Comments

@m-i-k-e
Copy link

m-i-k-e commented May 1, 2024

Context & versions

staging.sanchonet

Steps to reproduce

  1. Delegate to No Confidence
  2. Go to Dashboard

Actual behavior

The design is different than the one in Figma in several ways

  1. It is not expanded automatically, it should be
  2. It has a 'pill' on the closed Combi box that says "no confidence" - there is no design for this
  3. It has a 'selected' pill on the expanded combi box, again this is not in the designs

Expected behavior

Combo box should be expanded like in Figma.

Loom video

https://www.loom.com/share/ce2603435b5a4147a320de9a86c316a3?sid=d0f7e4f8-2108-4040-82dd-68e2519a08ec

@m-i-k-e m-i-k-e added the 🐛 Bug Something isn't working label May 1, 2024
@pmbinapps
Copy link

pmbinapps commented May 2, 2024

Issues mentioned in loop:

  • 'Wallet connected' msg - as a bug - it occurs just after reload of page - this is normal behaviour after Wallet connect if need to be removed in this case, decision is needed (@MSzalowski @Sworzen1 )

Image

  • 'NO CONFIDANCE' - label - should not be used - no such design. There is also no other design in( DRep explorer section ) screen how it should be presented. @m-i-k-e please add a link or screenshow how it should be shown

Image

  • 'Selected' label usage the same as above - not on design. Could find how this should be shown in DRep explorer section

Image

@m-i-k-e
Copy link
Author

m-i-k-e commented May 2, 2024

@pmbinapps @MSzalowski Here is the figma design: https://www.figma.com/file/mJTBiUofLfb74Xc3W2U59o/Voltaire---GOV-TOOL?type=design&node-id=12181%3A93328&mode=design&t=ALxcq4IdeSpWx8J0-1

Please note: it is missing the "Voting Power and buttons. This is an omission in Figma. Could you add it?

@pmbinapps pmbinapps moved this to To do in Govtool all May 7, 2024
@JanJaroszczak JanJaroszczak self-assigned this May 8, 2024
@JanJaroszczak JanJaroszczak moved this from To do to In progress in Govtool all May 8, 2024
@JanJaroszczak JanJaroszczak moved this from In progress to In review in Govtool all May 8, 2024
@JanJaroszczak JanJaroszczak linked a pull request May 8, 2024 that will close this issue
5 tasks
JanJaroszczak added a commit that referenced this issue May 9, 2024
JanJaroszczak added a commit that referenced this issue May 9, 2024
JanJaroszczak added a commit that referenced this issue May 9, 2024
JanJaroszczak added a commit that referenced this issue May 9, 2024
…s-layout-fixes

[#918] Automated voting options layout fixes
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all May 9, 2024
@JanJaroszczak JanJaroszczak moved this from Done to In QA in Govtool all May 9, 2024
@m-i-k-e
Copy link
Author

m-i-k-e commented May 10, 2024

@pmbinapps Why is this blocked?

@pmbinapps
Copy link

pmbinapps commented May 14, 2024

Checked on dev-sancho:

OK for Abstain

Image

OK for No confidance

Image

Jam recording

@pmbinapps pmbinapps self-assigned this May 14, 2024
@pmbinapps
Copy link

OK on test-sancho - item is expanding itself when state of transaction is updated:

https://jam.dev/c/5c663751-869f-4b4a-b43c-64c8c485d28c

@MSzalowski
Copy link
Contributor

@pmbinapps Should this still be assigned to you?

@bosko-m bosko-m moved this from In staging to Done in Govtool all Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants