Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/sonar scanner #1016

Merged
merged 4 commits into from
May 14, 2024
Merged

Feat/sonar scanner #1016

merged 4 commits into from
May 14, 2024

Conversation

mesudip
Copy link
Contributor

@mesudip mesudip commented May 14, 2024

List of changes

  • Run tests before sonar-scanner analysis

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@mesudip mesudip requested review from placek and adgud as code owners May 14, 2024 04:39
@mesudip mesudip requested a review from NabinKawan May 14, 2024 04:39
@mesudip mesudip force-pushed the feat/sonar-scanner branch from aadc763 to eb952de Compare May 14, 2024 04:45
@mesudip mesudip force-pushed the feat/sonar-scanner branch from eb952de to 23ddf9e Compare May 14, 2024 04:49
@NabinKawan NabinKawan merged commit 16a578b into develop May 14, 2024
1 check passed
@NabinKawan NabinKawan deleted the feat/sonar-scanner branch May 14, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NabinKawan NabinKawan NabinKawan approved these changes

@placek placek Awaiting requested review from placek placek is a code owner

@adgud adgud Awaiting requested review from adgud adgud is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mesudip @NabinKawan