Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch proposal and drep metadata from metadata-validaiton-service #1143

Merged
merged 40 commits into from
Jun 7, 2024
Merged

Fetch proposal and drep metadata from metadata-validaiton-service #1143

merged 40 commits into from
Jun 7, 2024

Conversation

jankun4
Copy link
Contributor

@jankun4 jankun4 commented Jun 3, 2024 •
edited
Loading

List of changes

  • drep/list has new fields (bio, dRepName, email, references, metadataValid, metadataStatus)
  • new field in backend config (metadatavalidationmaxconcurrentrequests)

Checklist

  • 1142
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@jankun4 jankun4 linked an issue Jun 3, 2024 that may be closed by this pull request
Metadata validation problems #1142
Closed
@jankun4 jankun4 marked this pull request as ready for review June 3, 2024 13:12
@jankun4 jankun4 requested review from MSzalowski and Ryun1 as code owners June 3, 2024 13:12
@jankun4 jankun4 changed the title WIP Fetch proposal and drep metadata from metadata-validaiton-service Jun 6, 2024
@jankun4 jankun4 force-pushed the 1142-metadata-validation-problems branch from 1fb7535 to 3798dca Compare June 6, 2024 02:05
@MSzalowski MSzalowski force-pushed the 1142-metadata-validation-problems branch from 8130f4a to 30286d8 Compare June 6, 2024 12:35
@jankun4 jankun4 force-pushed the 1142-metadata-validation-problems branch from 99eeed3 to cf97688 Compare June 6, 2024 13:51
@MSzalowski MSzalowski force-pushed the 1142-metadata-validation-problems branch from cf97688 to 99eeed3 Compare June 6, 2024 13:55
@MSzalowski MSzalowski merged commit 204ae85 into develop Jun 7, 2024
3 of 4 checks passed
@MSzalowski MSzalowski deleted the 1142-metadata-validation-problems branch June 7, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metadata validation problems
3 participants
@jankun4 @MSzalowski @Sworzen1