Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Google tag manager in test stack #1336

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Configure Google tag manager in test stack #1336

merged 1 commit into from
Jun 19, 2024

Conversation

mesudip
Copy link
Contributor

@mesudip mesudip commented Jun 19, 2024

List of changes

  • pass GTM_ID env variable to frontend build.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@mesudip mesudip requested a review from NabinKawan June 19, 2024 09:04
@mesudip mesudip requested review from Ryun1 and MSzalowski as code owners June 19, 2024 09:04
NabinKawan
NabinKawan approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@NabinKawan NabinKawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mesudip mesudip merged commit 5436aea into develop Jun 19, 2024
1 check passed
@mesudip mesudip deleted the fixes/test-stack-gtm branch June 19, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NabinKawan NabinKawan NabinKawan approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mesudip @NabinKawan