Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test 3I 6D and 4H #1475

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Fix failing test 3I 6D and 4H #1475

merged 3 commits into from
Jul 5, 2024

Conversation

kneerose
Copy link
Contributor

@kneerose kneerose commented Jul 5, 2024

List of changes

  • Add st , nd, rd on the date regex of extractExpiryDateFromText function.
  • Remove the "learn more" assertion on disconnect state as "learn more" for proposing a governance action is no longer on dashboard.
  • Add an exact match for "In Progress" on the assertion for dRep registration, as "In Progress" is also taken from "DRep registration in progress"

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

kneerose added 3 commits July 5, 2024 09:58
Remove learn more button test of governance action in disconnect state as there is view proposal button instead of learn more
Make exact text match 'In Progress' in test 3I assertion as it is also taking in progress of
@kneerose kneerose requested review from NabinKawan and mesudip and removed request for MSzalowski, Sworzen1 and JanJaroszczak July 5, 2024 04:29
Copy link
Contributor

@NabinKawan NabinKawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants