Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: proposal draft test blocked by verify identity button #1548

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Fix: proposal draft test blocked by verify identity button #1548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ae83ed
chore: add 2s wait timeout after navigated to proposal discussion
kneerose Jul 10, 2024
073338f
fix: verify identity on navigation to proposal creation
kneerose Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/govtool-frontend/playwright/lib/pages/proposalSubmissionPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ export default class ProposalSubmissionPage {
async goto() {
await this.page.goto(`${environments.frontendUrl}/proposal_discussion`);

await this.page.waitForTimeout(2_000); // wait until page load properly

await this.verifyIdentityBtn.click();
await this.proposalCreateBtn.click();

Expand Down
3 changes: 2 additions & 1 deletion ...vtool-frontend/playwright/tests/7-proposal-submission/proposalSubmission.loggedin.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,8 @@ test.describe("Temporary proposal users", () => {

test.beforeEach(async () => {
proposalSubmissionPage = new ProposalSubmissionPage(userPage);
await proposalSubmissionPage.goto();
await proposalSubmissionPage.proposalCreateBtn.click();
await proposalSubmissionPage.continueBtn.click();

await proposalSubmissionPage.addLinkBtn.click();
proposalFormValue =
Expand Down