Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1940): handle CIP-119 doNotList field #1944

Closed
wants to merge 2 commits into from
Closed

fix(#1940): handle CIP-119 doNotList field #1944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
232302f
fix(#1934): make displaying own DRep in DRep directory available
MSzalowski Sep 5, 2024
5621db0
fix(#1940): handle CIP-119 doNotList field
MSzalowski Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ changes.

### Fixed

-
- Handle CIP-119 doNotList field [Issue 1940](https://github.com/IntersectMBO/govtool/issues/1940)

### Changed

-
- Make displaying own DRep in DRep directory available [Issue 1934](https://github.com/IntersectMBO/govtool/issues/1934)

### Removed

Expand Down
7 changes: 1 addition & 6 deletions govtool/frontend/src/pages/DRepDirectoryContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,12 +209,7 @@ export const DRepDirectoryContent: FC<DRepDirectoryContentProps> = ({
>
{dRepList?.length === 0 && <EmptyStateDrepDirectory />}
{dRepListToDisplay?.map((dRep) => {
if (
isSameDRep(dRep, myDrep?.view) ||
isSameDRep(dRep, inProgressDelegation)
) {
return null;
}
if (dRep.doNotList) return null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the problem is somewhere during registering, I've handled filtering here https://github.com/IntersectMBO/govtool/blob/develop/govtool/frontend/src/pages/DRepDirectoryContent.tsx#L102

return (
<Box key={dRep.drepId} component="li" sx={{ listStyle: "none" }}>
<DRepCard
Expand Down
Loading