Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1940] add doNotList as accepted key on DRep registration #1949

Merged
merged 1 commit into from
Sep 5, 2024
Merged

[#1940] add doNotList as accepted key on DRep registration #1949

merged 1 commit into from
Sep 5, 2024

Conversation

jdyczka
Copy link
Contributor

@jdyczka jdyczka commented Sep 5, 2024

List of changes

  • Fix saving the Do Not List checkbox value on DRep registration

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@jdyczka jdyczka requested review from placek and Ryun1 September 5, 2024 13:47
@jdyczka jdyczka requested a review from MSzalowski as a code owner September 5, 2024 13:47
@jdyczka jdyczka mentioned this pull request Sep 5, 2024
Closed
5 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

✅ All checks succeeded

@jdyczka jdyczka requested a review from bosko-m September 5, 2024 14:17
@jdyczka jdyczka merged commit dd8be91 into develop Sep 5, 2024
8 checks passed
@jdyczka jdyczka deleted the fix/1940-do-not-list-not-saved-on-registration branch September 5, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosko-m bosko-m bosko-m approved these changes

@placek placek Awaiting requested review from placek

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdyczka @bosko-m @j-dyczka