Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/test dependabot alerts #2197

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix/test dependabot alerts #2197

merged 2 commits into from
Oct 23, 2024

Conversation

kneerose
Copy link
Contributor

List of changes

  • Update cookie dependencies version on test-metrics-api and test-metadata-api
  • Update @types/node version on tests/govtool-frontend

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from mesudip October 23, 2024 05:46
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

mesudip
mesudip approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kneerose kneerose merged commit 91c2214 into develop Oct 23, 2024
4 checks passed
@kneerose kneerose deleted the fix/test-dependabot-alerts branch October 23, 2024 06:28
@github-actions GitHub Actions
Copy link

@kneerose
This PR is in the tag: develop-91c22145b9c4298254301e8bf5fdf7018d078ca1 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@kneerose
This PR is in the tag: develop-91c22145b9c4298254301e8bf5fdf7018d078ca1 , for govtool-metadata-validation service

@spannercode spannercode mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneerose @mesudip