Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#2316): hide vote totals for the particular governance actions #2363

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feat(#2316): hide vote totals for the particular governance actions #2363

merged 1 commit into from
Nov 15, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • hide vote totals for the particular governance actions

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Nov 12, 2024 that may be closed by this pull request
Hide vote totals for the groups that cant vote on a particular Governance Action type #2316
Closed
@MSzalowski MSzalowski requested a review from placek November 12, 2024 08:03
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@MSzalowski MSzalowski merged commit 628b78a into develop Nov 15, 2024
8 checks passed
@MSzalowski MSzalowski deleted the feat/2316-hide-vote-totals-for-the-groups-that-cant-vote-on-a-particular-governance-action-type branch November 15, 2024 08:15
@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-628b78a2fa5a08459dc64e270980db2b29083827 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-628b78a2fa5a08459dc64e270980db2b29083827 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

@MSzalowski
This PR is in the tag: develop-628b78a2fa5a08459dc64e270980db2b29083827 , for govtool-backend service

@kneerose kneerose mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@placek placek placek approved these changes

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide vote totals for the groups that cant vote on a particular Governance Action type
2 participants
@MSzalowski @placek