New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use valid anchor url, hash and return address in bulk loader #2380

Merged

mesudip merged 2 commits into IntersectMBO:develop from reeshavacharya:fix/valid-metadata

Nov 19, 2024

Contributor

reeshavacharya commented Nov 18, 2024

List of changes

Change
- Anchor for bulk gov-actions:
  - url: https://metadata-govtool.cardanoapi.io/data/gov-action-loader
  - hash: bcb2fadedbe928519ff000051d8e78ffcabadba0f92b91334cee3e8786491462
  - This was done so that goveranace actions can be viewed as having correctly formatted data
  - Example: a003201b997db0777751c1f8f3f1d5ca761248ce5fd683e886a647dca53c2039#0
- Stake address for update committee and treasury withdrawal
  - change stake address to e02fe0d8c1b1c600249e8b9663e18790425e9589ac17cb5ee952d54bee
  - This had to be done since stake addresses were randomly generated and not yet initialized, which was resulting in error while submitting the transaction

Checklist

My changes generate no new warnings
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the changelog
I have added tests that prove my fix is effective or that my feature works

reeshavacharya added 2 commits

November 18, 2024 12:11


          Use valid metadata and withdrawal return account in gov-action bulk l…

80feda9

…oader


          Update stake address on update committee action

f91006f

reeshavacharya requested review from Ryun1 and MSzalowski as code owners

November 18, 2024 11:17

mesudip approved these changes

View reviewed changes

Contributor

mesudip left a comment

Looks Good

mesudip merged commit 377d43b into IntersectMBO:develop

0 of 3 checks passed

github-actions bot commented Nov 19, 2024

@reeshavacharya
This PR is in the tag: develop-377d43b7844bbde58bd84011a15c240b93f07564 , for govtool-metadata-validation service

github-actions bot commented Nov 19, 2024

@reeshavacharya
This PR is in the tag: develop-377d43b7844bbde58bd84011a15c240b93f07564 , for govtool-frontend service

github-actions bot commented Nov 19, 2024

@reeshavacharya
This PR is in the tag: develop-377d43b7844bbde58bd84011a15c240b93f07564 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet