Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing ipfs gateway and project id env for test stack #2489

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Add missing ipfs gateway and project id env for test stack #2489

merged 1 commit into from
Dec 11, 2024
+8 −2

Conversation

kneerose
Copy link
Contributor

@kneerose kneerose commented Dec 9, 2024

List of changes

  • Add missing ipfs gateway and project id env for test stack

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

✅ All checks succeeded

@kneerose kneerose requested a review from mesudip December 11, 2024 04:03
mesudip
mesudip approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@kneerose kneerose merged commit 8130ffa into develop Dec 11, 2024
4 checks passed
@kneerose kneerose deleted the infra/test-chores branch December 11, 2024 04:04
@github-actions GitHub Actions
Copy link

@kneerose
This PR is in the tag: develop-8130ffa0457f367471bd827c1fc667ed0cd3a644 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

@kneerose
This PR is in the tag: develop-8130ffa0457f367471bd827c1fc667ed0cd3a644 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

@kneerose
This PR is in the tag: develop-8130ffa0457f367471bd827c1fc667ed0cd3a644 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@placek placek Awaiting requested review from placek placek is a code owner

@adgud adgud Awaiting requested review from adgud adgud is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneerose @mesudip