Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/210 sole voter wallet logic for registration and retirement #307

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Feat/210 sole voter wallet logic for registration and retirement #307

merged 4 commits into from
Feb 26, 2024

Conversation

JanJaroszczak
Copy link
Contributor

List of changes

  • Possibility of registering and retiring as a Sole Voter added

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

MSzalowski
MSzalowski requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change. User is not the best name for that variable - the rest is pretty good 👍

govtool/frontend/src/context/wallet.tsx Outdated Show resolved Hide resolved
govtool/frontend/src/models/api.ts
isRegisteredAsDRep: boolean;
wasRegisteredAsDRep: boolean;
isRegisteredAsSoleVoter: boolean;
wasRegisteredAsSoleVoter: boolean;
deposit: number;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be null

MSzalowski
MSzalowski approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@MSzalowski MSzalowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@JanJaroszczak JanJaroszczak merged commit 9aacf83 into feat/119-i-want-to-vote-on-behalf-of-myself-become-a-drep Feb 26, 2024
1 check passed
@JanJaroszczak JanJaroszczak deleted the feat/210-sole-voter-wallet-logic-for-registration-and-retirement branch February 26, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

@kickloop kickloop Awaiting requested review from kickloop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JanJaroszczak @MSzalowski