chore/546-handle-action-of-opening-usersnap-feedback-widget-on-the-custom-buttons #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sworzen1
requested review from
MSzalowski,
JanJaroszczak and
Ryun1
as code owners
MSzalowski
requested changes
Apr 11, 2024
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ changes. | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| - Inicjalize Usersnap into App [Issue 546](https://github.com/IntersectMBO/govtool/issues/546) | |||
There was a problem hiding this comment.
Typo: Inicjalize -> Inicialize
|
|
||
| export const UsersnapContext = React.createContext(defaultValues); | ||
|
|
||
| type API = { |
There was a problem hiding this comment.
Rename it to UsersnapAPI as at least me - I often search the repo for the API - so to not confuse myself 😅
| on: (eventName: SpaceEventName, callback: SpaceEventCallback) => void; | ||
| off: (eventName: SpaceEventName, callback: SpaceEventCallback) => void; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Suggested change
| type UsersnapProviderProps { | |
| initParams?: InitOptions | |
| children?: ReactNode | |
| } | |
| export const UsersnapProvider = ({ | |
| initParams, | |
| children | |
| }: UsersnapProviderProps |
MSzalowski
approved these changes
Apr 15, 2024
Sworzen1
force-pushed
the
chore/546-handle-action-of-opening-usersnap-feedback-widget-on-the-custom-buttons
branch
from
a99939a to
0382ff4
Compare
Sworzen1
deleted the
chore/546-handle-action-of-opening-usersnap-feedback-widget-on-the-custom-buttons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Checklist