Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#720] fix drep/info null values #721

Merged
merged 1 commit into from
Apr 15, 2024
Merged

[#720] fix drep/info null values #721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ changes.

### Fixed

- drep/info no longer returns null values [Issue 720](https://github.com/IntersectMBO/govtool/issues/720)
- drep/getVotes no longer returns 500 [Issue 685](https://github.com/IntersectMBO/govtool/issues/685)
- drep/info no longer returns 500 [Issue 676](https://github.com/IntersectMBO/govtool/issues/676)
- proposal/list search is case insensitive now [Issue 582](https://github.com/IntersectMBO/govtool/issues/582)
Expand Down
14 changes: 7 additions & 7 deletions govtool/backend/sql/get-drep-info.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,13 @@ DRepRegister AS (
DRepRetire AS (
SELECT
encode(AllRegistrationEntries.tx_hash, 'hex') as tx_hash,
AllRegistrationEntries.tx_id
AllRegistrationEntries.tx_id as tx_id
FROM
DRepRegister
LEFT JOIN
AllRegistrationEntries ON AllRegistrationEntries.deposit < 0
OR AllRegistrationEntries.voting_anchor_id IS NULL
WHERE AllRegistrationEntries.tx_id > DRepRegister.tx_id
AllRegistrationEntries ON (AllRegistrationEntries.deposit < 0
OR AllRegistrationEntries.voting_anchor_id IS NULL)
and AllRegistrationEntries.tx_id > DRepRegister.tx_id
ORDER BY
AllRegistrationEntries.tx_id asc

Expand All @@ -156,9 +156,9 @@ SoleVoterRetire AS (
FROM
SoleVoterRegister
LEFT JOIN
AllRegistrationEntries ON AllRegistrationEntries.deposit < 0
OR AllRegistrationEntries.voting_anchor_id IS NOT NULL
WHERE AllRegistrationEntries.tx_id > SoleVoterRegister.tx_id
AllRegistrationEntries ON (AllRegistrationEntries.deposit < 0
OR AllRegistrationEntries.voting_anchor_id IS NOT NULL)
AND AllRegistrationEntries.tx_id > SoleVoterRegister.tx_id
ORDER BY
AllRegistrationEntries.tx_id asc

Expand Down
Loading