Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: fix frontend #770

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

disassembler
Copy link
Contributor

  • adds js devshell to fix yarn.lock
  • parameterizes build to pass ENV vars

List of changes

  • Add / Fix / Change / Remove

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@disassembler disassembler force-pushed the sl/fix-nix-frontend branch 2 times, most recently from 2f7ceef to b520b76 Compare April 18, 2024 20:33
* adds `js` devshell to fix yarn.lock
* parameterizes build to pass ENV vars
* exposes nodeModules, staticSite and devShell in frontend
* adds overridable env variables when building staticSite
@MSzalowski
Copy link
Contributor

Thank you so much for fixing these 💪

Copy link
Member

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ryun1 Ryun1 merged commit 5483dd3 into IntersectMBO:develop Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants