Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix footer alignment across pages #827

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix: fix footer alignment across pages #827

merged 1 commit into from
Apr 22, 2024

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • add workaround box filling the area above the footer. Have in my mind that it can't be the final solution. We need to relayout the pages (that will be done with the composing architecture implementation). As current Footer is wrongly reused on multiple pages. That should not be needed.

@MSzalowski MSzalowski merged commit c3be91c into develop Apr 22, 2024
5 checks passed
@MSzalowski MSzalowski deleted the fix/footer-sticks-to-the-end-of-the-page-content branch April 22, 2024 18:26
@NabinKawan NabinKawan mentioned this pull request Apr 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanJaroszczak JanJaroszczak JanJaroszczak approved these changes

@Sworzen1 Sworzen1 Awaiting requested review from Sworzen1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSzalowski @JanJaroszczak