Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#876] add metadata/validate endpoint #889

Conversation

jankun4
Copy link
Contributor

@jankun4 jankun4 commented Apr 29, 2024

a/validate endpoint

List of changes

Added

  • metadata/validate endpoint (which under the hood calls /validate endpoint of metadata validation service)
  • all endpoint's returning proposals now return additional field "metadataStatus"

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@jankun4 jankun4 linked an issue Apr 29, 2024 that may be closed by this pull request
@jankun4 jankun4 force-pushed the 876-provide-metadata-validation-to-the-proposal-list-and-on-the-ga-creation branch from 37f3260 to 73f2c81 Compare April 29, 2024 23:15
@jankun4 jankun4 changed the title [#876] add metadat [#876] add metadata/validate endpoint Apr 29, 2024
Signed-off-by: jankun4 <michaljankun@gmail.com>
@jankun4 jankun4 force-pushed the 876-provide-metadata-validation-to-the-proposal-list-and-on-the-ga-creation branch from 73f2c81 to 3a8d4d9 Compare April 29, 2024 23:59
@jankun4 jankun4 force-pushed the 876-provide-metadata-validation-to-the-proposal-list-and-on-the-ga-creation branch from 3a8d4d9 to 49ba396 Compare May 8, 2024 10:32
@jankun4 jankun4 force-pushed the 876-provide-metadata-validation-to-the-proposal-list-and-on-the-ga-creation branch from 49ba396 to b8e3aa3 Compare May 8, 2024 10:38
Sworzen1 added 2 commits May 8, 2024 16:17
…d-on-the-ga-creation' of https://github.com/IntersectMBO/govtool into 876-provide-metadata-validation-to-the-proposal-list-and-on-the-ga-creation
// TODO: Remove this service and use the API service
export const METADATA_VALIDATION_API = axios.create({
baseURL: `${BASE_URL}/metadata-validation`,
baseURL: `${BASE_URL}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and now it just can be baseURL: BASE_URL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change

Signed-off-by: Bartlomiej Sworzen <b.sworzen@gmail.com>
@Sworzen1 Sworzen1 merged commit 0f27b2e into develop May 9, 2024
3 of 4 checks passed
@Sworzen1 Sworzen1 deleted the 876-provide-metadata-validation-to-the-proposal-list-and-on-the-ga-creation branch May 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide metadata validation to the proposal list and on the GA creation
3 participants