-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#876] add metadata/validate endpoint #889
Merged
Sworzen1
merged 5 commits into
develop
from
876-provide-metadata-validation-to-the-proposal-list-and-on-the-ga-creation
May 9, 2024
Merged
[#876] add metadata/validate endpoint #889
Sworzen1
merged 5 commits into
develop
from
876-provide-metadata-validation-to-the-proposal-list-and-on-the-ga-creation
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankun4
requested review from
MSzalowski,
Sworzen1,
JanJaroszczak and
Ryun1
as code owners
April 29, 2024 23:15
jankun4
force-pushed
the
876-provide-metadata-validation-to-the-proposal-list-and-on-the-ga-creation
branch
from
April 29, 2024 23:15
37f3260
to
73f2c81
Compare
Signed-off-by: jankun4 <michaljankun@gmail.com>
jankun4
force-pushed
the
876-provide-metadata-validation-to-the-proposal-list-and-on-the-ga-creation
branch
from
April 29, 2024 23:59
73f2c81
to
3a8d4d9
Compare
MSzalowski
approved these changes
Apr 30, 2024
jankun4
force-pushed
the
876-provide-metadata-validation-to-the-proposal-list-and-on-the-ga-creation
branch
from
May 8, 2024 10:32
3a8d4d9
to
49ba396
Compare
jankun4
force-pushed
the
876-provide-metadata-validation-to-the-proposal-list-and-on-the-ga-creation
branch
from
May 8, 2024 10:38
49ba396
to
b8e3aa3
Compare
…d-on-the-ga-creation' of https://github.com/IntersectMBO/govtool into 876-provide-metadata-validation-to-the-proposal-list-and-on-the-ga-creation
MSzalowski
approved these changes
May 9, 2024
govtool/frontend/src/services/API.ts
Outdated
// TODO: Remove this service and use the API service | ||
export const METADATA_VALIDATION_API = axios.create({ | ||
baseURL: `${BASE_URL}/metadata-validation`, | ||
baseURL: `${BASE_URL}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and now it just can be baseURL: BASE_URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change
Signed-off-by: Bartlomiej Sworzen <b.sworzen@gmail.com>
Sworzen1
deleted the
876-provide-metadata-validation-to-the-proposal-list-and-on-the-ga-creation
branch
May 9, 2024 13:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a/validate endpoint
List of changes
Added
metadata/validate
endpoint (which under the hood calls /validate endpoint of metadata validation service)Checklist