Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#927] Your DRep needs showing on detail page #985

Merged
merged 2 commits into from
May 14, 2024

Conversation

JanJaroszczak
Copy link
Contributor

@JanJaroszczak JanJaroszczak commented May 10, 2024

List of changes

  • "Yourself" pill has been added to DRep details page, so that it is consistent with DRep Card in DRep Directory

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@JanJaroszczak JanJaroszczak linked an issue May 10, 2024 that may be closed by this pull request
@Sworzen1
Copy link
Contributor

Sworzen1 commented May 10, 2024

In my opinion, that's not what this bug is about. We need to inform a user, this is the DRep, who my voting power has delegated . Block the delegate button for this DRep additionally.
reference to Figma and on right side you have DRep connected to your wallet, you can change this pill as well.

@MSzalowski
Copy link
Contributor

MSzalowski commented May 10, 2024

@JanJaroszczak Could you submit a screenshot of the incoming change?

I think that @Sworzen1 is right about this. We have 2 scenarios: for the drep that we delegate to and for our drep. Pill yourself is not part of that functionality even though it is existing on the main drep list view.

Check referenced figma file

@JanJaroszczak JanJaroszczak requested a review from Ryun1 as a code owner May 13, 2024 12:11
@JanJaroszczak JanJaroszczak removed the request for review from Ryun1 May 13, 2024 19:21
@JanJaroszczak JanJaroszczak force-pushed the 927-your-drep-needs-showing-on-detail-page branch from 8bc4b74 to e33383b Compare May 13, 2024 19:23
@JanJaroszczak
Copy link
Contributor Author

JanJaroszczak commented May 13, 2024

@MSzalowski, @Sworzen1

DRep details I delegated to ("not-self" DRep). Besides, to do it, I also had to fix a bug described here: #931.

Zrzut ekranu 2024-05-13 o 21 35 18 Zrzut ekranu 2024-05-13 o 21 35 30

@JanJaroszczak
Copy link
Contributor Author

"Self" DRep:
Zrzut ekranu 2024-05-13 o 21 33 03
Zrzut ekranu 2024-05-13 o 21 33 30

@JanJaroszczak JanJaroszczak merged commit 7c6003b into develop May 14, 2024
4 of 5 checks passed
@JanJaroszczak JanJaroszczak deleted the 927-your-drep-needs-showing-on-detail-page branch May 14, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Your DRep" needs showing on detail page
3 participants