-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for measures to LocalTxMonitor #1191
Draft
fraser-iohk
wants to merge
18
commits into
main
Choose a base branch
from
fraser-iohk/localtxmonitor-measures
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Aug 26, 2024
-
consensus: consolidate transaction limits in the mempool
Remove `Mempool.`getTxSize`; the snapshot interface contains sizes now. Transaction size, block capacity, and mempool capacity are multi-dimensional vectors (incl ExUnits, etc), instead of merely bytes: see `TxMeasure`. A transaction cannot be added if it would push any component of the size over that component's capacity. The capacity override is still only specified in byte size, but the value is interpreted as a block count (rounded up). Enforce block capacity _before_ the forging logic. Now the forging logic simply includes whatever transactions its given, which is reasonable and simpler. It's the NodeKernel logic that uses the mempool's finger tree in order to slice an appropriately-sized prefix, which is then passed to the now-dumb forging function. consensus: no longer need BoundedMeasure, Measure suffices consensus-cardano: use ConwayMeasure in Babbage TOSQUASH fixup overflow workarounds and their explanations consensus: update stale tryAddTxs Haddock references consensus: an editing pass on the addTx Haddock consensus: elaborate comment on pureTryAddTx guard consensus: mitigate new mempool DoS vector consensus: txMeasure now fails if the tx is too big TOSQUASH fixup hlint and 9.* build TOSQUASH fixup stylish TOSQUASH polishing consensus: explicit overflow check in pureTryAddTx consensus: Word32 for tx byte size instead of Natural consensus: mention Segregated Witness scheme in tx byte size comment
Configuration menu - View commit details
-
Copy full SHA for a1858ab - Browse repository at this point
Copy the full SHA a1858abView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee1400e - Browse repository at this point
Copy the full SHA ee1400eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f205db6 - Browse repository at this point
Copy the full SHA f205db6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a72535c - Browse repository at this point
Copy the full SHA a72535cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 695fe1f - Browse repository at this point
Copy the full SHA 695fe1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b67443d - Browse repository at this point
Copy the full SHA b67443dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe778a3 - Browse repository at this point
Copy the full SHA fe778a3View commit details
Commits on Aug 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f15f603 - Browse repository at this point
Copy the full SHA f15f603View commit details
Commits on Aug 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e45d9da - Browse repository at this point
Copy the full SHA e45d9daView commit details -
add
fromByteSize :: Num a => ByteSize -> a
, with a WARNING that it ……will likely explode due to overflow
Configuration menu - View commit details
-
Copy full SHA for 3cc888a - Browse repository at this point
Copy the full SHA 3cc888aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 310d435 - Browse repository at this point
Copy the full SHA 310d435View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4387891 - Browse repository at this point
Copy the full SHA 4387891View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac1979c - Browse repository at this point
Copy the full SHA ac1979cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 529d4e7 - Browse repository at this point
Copy the full SHA 529d4e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02e944d - Browse repository at this point
Copy the full SHA 02e944dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1475242 - Browse repository at this point
Copy the full SHA 1475242View commit details
Commits on Sep 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 159d33f - Browse repository at this point
Copy the full SHA 159d33fView commit details
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 804a8f9 - Browse repository at this point
Copy the full SHA 804a8f9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.