Implement the Cached index using TVars #1197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
nfrisby,
amesgen,
fraser-iohk,
dnadales and
RenateEilers
as code owners
jasagredo
force-pushed
the
js/tvar-cache
branch
2 times, most recently
from
9f26a42
to
b822723
Compare
jasagredo
commented
Jul 31, 2024
...onsensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ImmutableDB/Impl/Index/Cache.hs
Outdated
Show resolved
Hide resolved
...onsensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/ImmutableDB/Impl/Index/Cache.hs
Show resolved
Hide resolved
jasagredo
force-pushed
the
js/tvar-cache
branch
3 times, most recently
from
4c1408f
to
0533805
Compare
In the past some nodes have been crashing because of a misalingment in the data in the Cached Index. Ensuring that the changes are atomic via `stm` seems to solve the problem. In terms of logic, this PR only moves the modifications into `atomically` blocks, the overall logic is the same.
jasagredo
force-pushed
the
js/tvar-cache
branch
from
0533805
to
3a3bee6
Compare
jorisdral
reviewed
Aug 1, 2024
| return $ Just $ Right pastChunkInfo | ||
| | otherwise -> do | ||
| ((Just $ Right pastChunkInfo, TracePastChunkHit chunk nbPastChunks), cached') | ||
| | otherwise -> | ||
| -- Cache miss for an chunk in the past. We don't want to hold on to | ||
| -- the 'cacheVar' MVar, blocking all other access to the cace, while |
There was a problem hiding this comment.
Suggested change
| -- the 'cacheVar' MVar, blocking all other access to the cace, while | |
| -- the 'cacheVar' TVar, blocking all other access to the cace, while |
nfrisby
reviewed
Aug 21, 2024
| @@ -409,13 +409,14 @@ newEnv hasFS registry tracer cacheConfig chunkInfo chunk = do | |||
| -- Will expire past chunks that haven't been used for 'expireUnusedAfter' from | |||
| -- the cache. | |||
| expireUnusedChunks :: | |||
| forall h m blk. | |||
There was a problem hiding this comment.
unnecessary tyvar bindings?
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past some nodes have been crashing because of a misalingment in the data in the Cached Index. Ensuring that the changes are atomic via
stmseems to solve the problem.In terms of logic, this PR only moves the modifications into
atomicallyblocks, the overall logic is the same.Depends on #1196
Closes #359