Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Genesis benchmarks #1209

Draft
wants to merge 76 commits into
base: main
Choose a base branch
from
Draft

[WIP] Genesis benchmarks #1209

wants to merge 76 commits into from

Commits on Jul 23, 2024

  1. Introduce a collection of chainsync handles that synchronizes a map a… 

    …nd a queue
    @facundominguez
    facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1369102 View commit details
    Browse the repository at this point in the history

  2. Implement a call to rotate dynamos in CSJ

    @facundominguez
    facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e3be2f1 View commit details
    Browse the repository at this point in the history

  3. Comment formatting 

    Co-authored-by: Nicolas Jeannerod <niols@niols.fr>
    @facundominguez @Niols
    facundominguez and Niols committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3c42b51 View commit details
    Browse the repository at this point in the history

  4. Rename varHandles to readHandles for consistency

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    407db3b View commit details
    Browse the repository at this point in the history

  5. Mention that the objector also gets demoted

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    92ff252 View commit details
    Browse the repository at this point in the history

  6. Specify the order in which to start the peers

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d7d7acc View commit details
    Browse the repository at this point in the history

  7. Add a BlockFetch leashing attack test

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    705daf4 View commit details
    Browse the repository at this point in the history

  8. Switch peer simulator to FetchModeBulkSync

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8bd6815 View commit details
    Browse the repository at this point in the history

  9. Track the last time the ChainDB thread was starved

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    31705f2 View commit details
    Browse the repository at this point in the history

  10. Plug rotateDynamo into BlockFetchConsensusInterface

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b20f711 View commit details
    Browse the repository at this point in the history

  11. Change how last starvation is recorded 

    Previously, we only registered the time at which starvation started.
This is in fact not enough: if after the grace period the peer is still
not making us unstarved, we won't detect it. Instead, we record the last
starvation as either ongoing or we record its end time.
    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e894140 View commit details
    Browse the repository at this point in the history

  12. Revert "GSM: use diffusion layer info for HAA" 

    This reverts commit 4946b3b.
    @facundominguez
    facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ebc49ce View commit details
    Browse the repository at this point in the history

  13. Fix starvation detection; improve tracing

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    7beffdc View commit details
    Browse the repository at this point in the history

  14. Follow changes of tracing in peer simulator

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d3dbdf8 View commit details
    Browse the repository at this point in the history

  15. Follow configurable grace period

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b0946d3 View commit details
    Browse the repository at this point in the history

  16. Allow parameterizing whether chainsel starvation is handled

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2d51933 View commit details
    Browse the repository at this point in the history

  17. Trace the time at which starvation started

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    90d613c View commit details
    Browse the repository at this point in the history

  18. stylish haskell

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    50ac9b1 View commit details
    Browse the repository at this point in the history

  19. Follow change in trace chainselstarvationstarted

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    60d0d62 View commit details
    Browse the repository at this point in the history

  20. ChainDB: let the BlockFetch client add blocks asynchronously 

    This is a port of PR IntersectMBO/ouroboros-network#2721 to the new ChainSelQueue.

Co-authored-by: mrBliss <thomas@well-typed.com>
    @Niols @mrBliss @facundominguez
    2 people authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1efae68 View commit details
    Browse the repository at this point in the history

  21. Some wiggle room for duplicate headers

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    91bf46d View commit details
    Browse the repository at this point in the history

  22. Disable chainsel starvation in CSJ test

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    bc445da View commit details
    Browse the repository at this point in the history

  23. Depend on the ouroboros-network fork with the latest blockfetch

    @facundominguez
    facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e93b423 View commit details
    Browse the repository at this point in the history

  24. Accomodate for the addition of ChainSyncClientHandleCollection and gr… 

    …ace period and starvation event in BlockFetch
    @facundominguez
    facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5e5b37d View commit details
    Browse the repository at this point in the history

  25. Follow removal of bfcMaxConcurrencyBulkSync

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5aaa882 View commit details
    Browse the repository at this point in the history

  26. Only log starvations when they actually start

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    7ac6a88 View commit details
    Browse the repository at this point in the history

  27. Revert "ChainDB: let the BlockFetch client add blocks asynchronously" 

    This reverts commit 09e9837.
    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    956332f View commit details
    Browse the repository at this point in the history

  28. Add explicit tracing events for CSJ

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e742b01 View commit details
    Browse the repository at this point in the history

  29. Follow changes in blockfetch decision tracing

    @Niols @facundominguez
    Niols authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a12cd89 View commit details
    Browse the repository at this point in the history

  30. Move Genesis-specific BlockFetch config to GenesisConfig

    @nbacquey @facundominguez
    nbacquey authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    eafa6a4 View commit details
    Browse the repository at this point in the history

  31. Add missing instances for TraceChainSetStarvationEvent

    @nbacquey @facundominguez
    nbacquey authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    4500891 View commit details
    Browse the repository at this point in the history

  32. Reapply "ChainDB: let the BlockFetch client add blocks asynchronously" 

    This reverts commit 310d3a9.
    @facundominguez
    facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ff5f040 View commit details
    Browse the repository at this point in the history

  33. Stop measuring starvation when blocks arrive

    @facundominguez
    facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ea486e7 View commit details
    Browse the repository at this point in the history

  34. Introduce GenesisConfigFlags for interaction with config files/CLI

    @nbacquey @facundominguez
    nbacquey authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8226db3 View commit details
    Browse the repository at this point in the history

  35. Add missing instances for Genesis configuration

    @nbacquey @facundominguez
    nbacquey authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    eb8de6e View commit details
    Browse the repository at this point in the history

  36. Set the jump size to smaller size for byron

    @facundominguez
    facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    70f6713 View commit details
    Browse the repository at this point in the history

  37. export default Genesis config flags

    @nbacquey @facundominguez
    nbacquey authored and facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    315ea7e View commit details
    Browse the repository at this point in the history

  38. Fix ouroboros-consensus-diffusion:test:consensus-test

    @facundominguez
    facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    07dab6b View commit details
    Browse the repository at this point in the history

  39. Fix ouroboros-consensus:test:consensus-test

    @facundominguez
    facundominguez committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8b510ce View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Accomodate for the addition of ChainSyncClientHandleCollection and gr… 

    …ace period and starvation event in BlockFetch
    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    d9ea987 View commit details
    Browse the repository at this point in the history

  2. Reapply "GSM: use diffusion layer info for HAA" 

    This reverts commit 66ab269.
    @amesgen @facundominguez
    amesgen authored and facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6bb240e View commit details
    Browse the repository at this point in the history

  3. Limit the rate at which GDD is evaluated

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    a8111f7 View commit details
    Browse the repository at this point in the history

  4. Edit note on Interactions with the BlockFetch logic

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6961bd4 View commit details
    Browse the repository at this point in the history

  5. Accomodate for separate decision loop intervals for fetch modes

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    b605fed View commit details
    Browse the repository at this point in the history

  6. fixup: Adding rate limit to GDD

    @facundominguez
    facundominguez committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    7841fb5 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Set the default jump size to 2k

    @facundominguez
    facundominguez committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    314616f View commit details
    Browse the repository at this point in the history

  2. Relax expectations of test blockFetch in the BulkSync case

    @facundominguez
    facundominguez committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    889a149 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Set the GDD rate limit to 0 in the peer simulator

    @facundominguez
    facundominguez committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    c93d7df View commit details
    Browse the repository at this point in the history

  2. Accomodate for timer added in blockFetchLogic

    @facundominguez
    facundominguez committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    bc2bb70 View commit details
    Browse the repository at this point in the history

  3. Have the peer simulator use the default grace period for chainsel sta… 

    …rvations
    @facundominguez
    facundominguez committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    62981db View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. ChainSync client: disconnect if stuck and not better than selection 

    TODO better docs
    @amesgen
    amesgen committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    1c6498e View commit details
    Browse the repository at this point in the history

  2. Shift point schedule times before giving the schedules to tests

    @facundominguez
    facundominguez committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    4c212aa View commit details
    Browse the repository at this point in the history

  3. Allow to run the decision logic once after the last tick in the block… 

    …fetch leashing attack
    @facundominguez
    facundominguez committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    42b9ff4 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Update LoP tests to run 1000 times each

    @facundominguez
    facundominguez committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    e73e43a View commit details
    Browse the repository at this point in the history

  2. Run more repetitions of LoE tests

    @facundominguez
    facundominguez committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    aeb3290 View commit details
    Browse the repository at this point in the history

  3. Print timestamps for node restarts

    @facundominguez
    facundominguez committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1ff5343 View commit details
    Browse the repository at this point in the history

  4. Disable boring timeouts in the node restart test

    @facundominguez
    facundominguez committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    99edbed View commit details
    Browse the repository at this point in the history

  5. Wait sufficiently long after restarting the node at the end of a test

    @facundominguez
    facundominguez committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    499a95d View commit details
    Browse the repository at this point in the history

  6. Don't let GDD drop candidates that do not intersect with the selection

    @facundominguez
    facundominguez committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    db3eb9f View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Genesis tests: remove outdated comment

    @amesgen
    amesgen committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    8eb4ea2 View commit details
    Browse the repository at this point in the history

  2. disableBoringTimeouts: don't consider canAwaitTimeout boring 

    This is relatively tight by default (10s), and applies eg to adversaries that
simply stop sending headers
    @amesgen
    amesgen committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    833d2ec View commit details
    Browse the repository at this point in the history

  3. Disable canAwaitTimeout again in the timed leashing attack

    @facundominguez
    facundominguez committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    83ff29e View commit details
    Browse the repository at this point in the history

  4. Document treatment of fragments with no intersection with the selecti… 

    …on in GDD
    @facundominguez
    facundominguez committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3d65fb1 View commit details
    Browse the repository at this point in the history

  5. fixup! ChainSync client: disconnect if stuck and not better than sele… 

    …ction
    @amesgen
    amesgen committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    6a184e5 View commit details
    Browse the repository at this point in the history

  6. Edit note on truncation of candidate fragments

    @facundominguez
    facundominguez committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c750764 View commit details
    Browse the repository at this point in the history

  7. Expand the comments motivating DynamoInitState and ObjectorInitState

    @facundominguez
    facundominguez committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    8eaf5dc View commit details
    Browse the repository at this point in the history

  8. Expect CandidateTooSparse in gdd tests

    @facundominguez
    facundominguez committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c94e8ef View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Run CSJ and gdd tests more times by default

    @facundominguez
    facundominguez committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    39b4877 View commit details
    Browse the repository at this point in the history

  2. Add a notice about untracked delays in the node restart test

    @facundominguez
    facundominguez committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    0f22ff1 View commit details
    Browse the repository at this point in the history

  3. Remove redundant empty window check from the GDD

    @facundominguez
    facundominguez committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    ab33a03 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. fixup! ChainDB: let the BlockFetch client add blocks asynchronously

    @amesgen
    amesgen committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    23542f9 View commit details
    Browse the repository at this point in the history

  2. Introduce peersOnlyAdversary and classify abnormal test peers as ad… 

    …versarial
    @nbacquey
    nbacquey committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d15230e View commit details
    Browse the repository at this point in the history

  3. Document all tests that did not have documentation

    @Niols
    Niols committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    bcb2c11 View commit details
    Browse the repository at this point in the history

  4. lint: stylish-haskell

    @nbacquey
    nbacquey committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    88c10cd View commit details
    Browse the repository at this point in the history

  5. Update source-repository-package to `blockfetch/milestone-1-rebased… 

    …` in `ouroboros-network`
    @nbacquey
    nbacquey committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    bfc0cac View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Document prop_blockFetchLeashingAttack

    @Niols
    Niols committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f907373 View commit details
    Browse the repository at this point in the history