-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typed Protocols: new API #1223
Typed Protocols: new API #1223
Conversation
9c13191
to
a65b059
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description seems a bit off.
- It's version 0.3.0.0, not version 0.2.0.0.
- I don't see any aspects of
SizeInBytes
within the diff itself.
The diff itself looked totally fine. I don't follow the new Stateful
stuff yet, but everything here seems very reasonable.
I'm not Approving because of:
- The above concerns about the PR description.
- I don't think we want an
source-repository-package
stanza on themain
branch. Will the relevant dependencies be uploaded to CHaP soon enough to wait for them?
I started with |
ekg-forward 0.6 which is going into the next node release is incompatible with new typed-protocols 0.3 so lets hold off on merging this PR. |
@crocodile-dentist |
I also left TODO notes to add PeerSharing tracer.
518a441
to
cb6fb68
Compare
`NodeToClientV_19` was added.
cb6fb68
to
c4b3116
Compare
Yes, but it would have caused problems downstream when releasing node - consensus would have to release off branch to make it go smoothest. |
c4b3116
to
254aa51
Compare
...sensus-diffusion/src/ouroboros-consensus-diffusion/Ouroboros/Consensus/Network/NodeToNode.hs
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Util/IOLike.hs
Show resolved
Hide resolved
The requested changes have been addressed.
ouroboros-consensus/test/consensus-test/Test/Consensus/BlockchainTime/Simple.hs
Outdated
Show resolved
Hide resolved
be7c0f2
to
120d92d
Compare
Description
Use
typed-protocols-0.3.0.0
.Depends on: