Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal workaround for updating protocol params on Babbage→Conway #366

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Sep 25, 2023

Closes IntersectMBO/cardano-ledger#3491 in an ad-hoc but minimal fashion.

Primary motivation is to fix this bug on Sanchonet without having to wait for the full HFC refactoring (see #345) that we will probably end up with.

@amesgen amesgen requested a review from a team as a code owner September 25, 2023 10:24
Copy link
Contributor

@nfrisby nfrisby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

This change is explicitly confined to Babbage->Conway, so syncing SanchoNet will validate it.

@amesgen amesgen added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit a70f0f3 Sep 25, 2023
12 checks passed
@amesgen amesgen deleted the amesgen/minimal-babbage-conway-protver-fix branch September 25, 2023 12:40
github-merge-queue bot pushed a commit that referenced this pull request Sep 28, 2023
Also inlcudes changelog entries for #366 and the first commit in #323
(second commit was reverted in #362).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cardano-cli reports protocol version 8 in Conway era
2 participants