Remove ChainFragment #2778
Merged
Remove ChainFragment #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
force-pushed
the
mrBliss/remove-chainfragment
branch
2 times, most recently
from
010778d
to
d45af33
Compare
|
I added the |
edsko
approved these changes
Nov 30, 2020
`ChainFragment`s were hardly ever used anymore, only in some tests. We use `AnchoredFragment`s almost everywhere. There are very few situations in which you *don't* want an anchor. This means that `ChainFragment`s are only really there to make implementing `AnchoredFragment`s easier, i.e., by wrapping them. However, we can simply inline them, dropping tons of code in the process. In the process, simplify the chain and fragment generators. Drop a few pattern synonyms. Stop using block number 0 for genesis and remove `legacyHeadBlockNo`.
mrBliss
force-pushed
the
mrBliss/remove-chainfragment
branch
from
d45af33
to
25c9f29
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChainFragments were hardly ever used anymore, only in some tests. We useAnchoredFragments almost everywhere. There are very few situations in whichyou don't want an anchor.
This means that
ChainFragments are only really there to make implementingAnchoredFragments easier, i.e., by wrapping them. However, we can simplyinline them, dropping tons of code in the process.
In the process, simplify the chain and fragment generators. Drop a few pattern
synonyms. Stop using block number 0 for genesis and remove
legacyHeadBlockNo.